[GitHub] [jena] fkleedorfer commented on a change in pull request #870: Add public getters to SHACL constraint implementations

[GitBox <gi...@apache.org>]

fkleedorfer commented on a change in pull request #870:
URL: https://github.com/apache/jena/pull/870#discussion_r530253747



##########
File path: jena-shacl/src/main/java/org/apache/jena/shacl/engine/constraint/ConstraintComponentSPARQL.java
##########
@@ -59,6 +59,18 @@ public ConstraintComponentSPARQL(SparqlComponent sparqlConstraintComponent,
         }
     }
 
+    public SparqlComponent getSparqlConstraintComponent() {
+        return sparqlConstraintComponent;
+    }
+
+    public Multimap<Parameter, Node> getParameterMap() {
+        return parameterMap;

Review comment:
       Sorry, good catch. I think wrapping with unmodifiable collections or cloning in the getter should do. I'll add another commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org