[GitHub] [tvm] zxybazh commented on a diff in pull request #12035: [MetaSchedule][TIR] Patch for Data Type Inconsistency After Trace Reloading

[GitBox <gi...@apache.org>]

zxybazh commented on code in PR #12035:
URL: https://github.com/apache/tvm/pull/12035#discussion_r916435643


##########
src/tir/schedule/concrete_schedule.cc:
##########
@@ -452,6 +452,9 @@ Array<LoopRV> ConcreteScheduleNode::Split(const LoopRV& loop_rv,
       if (is_const_int(factor) && !is_positive_const(factor)) {
         throw NonPositiveFactorError(state_->mod, factor.as<IntImmNode>()->value, i);
       }
+      if (factor.dtype().bits() > loop->extent.dtype().bits()) {
+        factor = tir::Cast(loop->extent.dtype(), factor);

Review Comment:
   Do you mean `tvm::cast` not `tir::cast` right? There seems to be no lowercased cast in tir namespace.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org