You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/03/03 13:15:22 UTC

[GitHub] [incubator-heron] nicknezis commented on pull request #3786: Fix for missing physical plan in UI

nicknezis commented on pull request #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1058030433


   Nice catch. The tests seem to work for me, but there's definitely more to clean up as you mentioned. I guess I started making the code match this line: https://github.com/apache/incubator-heron/blob/4d1ab84eea99a374c6838cb9401d6a7fc908af24/heron/tools/ui/resources/static/js/stat-trendlines.js#L264 with the assumption we had broken something in the Tracker cleanup. But looking back at old versions of the code, this UI query may never have matched up with the tracker api. Very odd. I personally prefer the `/metrics/query` syntax, but might be easier to just roll back to `/metricsquery` style route. And instead I'll update the javascript to use the proper api call.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org