You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by bowen zhang <bo...@yahoo.com.INVALID> on 2014/06/09 23:25:50 UTC
JPAService.destroy() issue
Hi Mohammad,
I saw you wrote the line "factory.close()" in the destroy method of
JPAService.java. I've seen some issues of this line throwing
invalidStateException while there is active transaction happening,
particularly on Windows. Can you tell me how you make sure there is no
active transaction when shutting down oozie? Should this line be
deleted?
Thanks,Bowen
Re: JPAService.destroy() issue
Posted by bowen zhang <bo...@yahoo.com.INVALID>.
no, the exception will stop the shutdown. It will make oozie unable to shutdown.
On Tuesday, June 10, 2014 12:46 PM, Rohini Palaniswamy <ro...@gmail.com> wrote:
I don't think it will be wise to remove that line as factory.close() is
required to cleanup and release resources. Since the exception is during
shutdown and is just logged and does not affect the shutdown I don't think
you should be worrying about removing it.
On Mon, Jun 9, 2014 at 11:24 PM, Mohammad Islam <mi...@yahoo.com.invalid>
wrote:
> In that case, it is an issue.
>
> Can someone else also make comments about the impact of removing the
> "factory.destroy()"?
> I know the Oozie team at Y! made substantial investigations in the DB
> access layer.
>
> Regards,
> Mohammad
>
>
>
> On Monday, June 9, 2014 4:44 PM, bowen zhang
> <bo...@yahoo.com.INVALID> wrote:
>
>
>
> Mohammad, there is no code insuring all active transactions are closed.
>
>
>
>
> On Monday, June 9, 2014 2:53 PM, Mohammad Islam <mi...@yahoo.com.INVALID>
> wrote:
>
>
>
> Bowen,
> This has been done a long time back. I can't recall the full context.
> However, it is better to make sure all transactions are completed before
> closing it.
>
> Is there a way to do that? This will be a safer approach.
>
>
> Deleting the line looks little risky. We need to close the factory. right?
> Will it keep some resource leaking?
>
> If we can find any references that it is not required, we can delete the
> line.
>
>
> Regards,
> Mohammad
>
>
>
>
> On Monday, June 9, 2014 2:33 PM, bowen zhang
> <bo...@yahoo.com.INVALID> wrote:
>
>
>
> Hi Mohammad,
> I saw you wrote the line "factory.close()" in the destroy method of
> JPAService.java. I've seen some issues of this line throwing
> invalidStateException while there is active transaction happening,
> particularly on Windows. Can you tell me how you make sure there is no
> active transaction when shutting down oozie? Should this line be
> deleted?
> Thanks,Bowen
>
Re: JPAService.destroy() issue
Posted by Rohini Palaniswamy <ro...@gmail.com>.
I don't think it will be wise to remove that line as factory.close() is
required to cleanup and release resources. Since the exception is during
shutdown and is just logged and does not affect the shutdown I don't think
you should be worrying about removing it.
On Mon, Jun 9, 2014 at 11:24 PM, Mohammad Islam <mi...@yahoo.com.invalid>
wrote:
> In that case, it is an issue.
>
> Can someone else also make comments about the impact of removing the
> "factory.destroy()"?
> I know the Oozie team at Y! made substantial investigations in the DB
> access layer.
>
> Regards,
> Mohammad
>
>
>
> On Monday, June 9, 2014 4:44 PM, bowen zhang
> <bo...@yahoo.com.INVALID> wrote:
>
>
>
> Mohammad, there is no code insuring all active transactions are closed.
>
>
>
>
> On Monday, June 9, 2014 2:53 PM, Mohammad Islam <mi...@yahoo.com.INVALID>
> wrote:
>
>
>
> Bowen,
> This has been done a long time back. I can't recall the full context.
> However, it is better to make sure all transactions are completed before
> closing it.
>
> Is there a way to do that? This will be a safer approach.
>
>
> Deleting the line looks little risky. We need to close the factory. right?
> Will it keep some resource leaking?
>
> If we can find any references that it is not required, we can delete the
> line.
>
>
> Regards,
> Mohammad
>
>
>
>
> On Monday, June 9, 2014 2:33 PM, bowen zhang
> <bo...@yahoo.com.INVALID> wrote:
>
>
>
> Hi Mohammad,
> I saw you wrote the line "factory.close()" in the destroy method of
> JPAService.java. I've seen some issues of this line throwing
> invalidStateException while there is active transaction happening,
> particularly on Windows. Can you tell me how you make sure there is no
> active transaction when shutting down oozie? Should this line be
> deleted?
> Thanks,Bowen
>
Re: JPAService.destroy() issue
Posted by Mohammad Islam <mi...@yahoo.com.INVALID>.
In that case, it is an issue.
Can someone else also make comments about the impact of removing the "factory.destroy()"?
I know the Oozie team at Y! made substantial investigations in the DB access layer.
Regards,
Mohammad
On Monday, June 9, 2014 4:44 PM, bowen zhang <bo...@yahoo.com.INVALID> wrote:
Mohammad, there is no code insuring all active transactions are closed.
On Monday, June 9, 2014 2:53 PM, Mohammad Islam <mi...@yahoo.com.INVALID> wrote:
Bowen,
This has been done a long time back. I can't recall the full context.
However, it is better to make sure all transactions are completed before closing it.
Is there a way to do that? This will be a safer approach.
Deleting the line looks little risky. We need to close the factory. right?
Will it keep some resource leaking?
If we can find any references that it is not required, we can delete the line.
Regards,
Mohammad
On Monday, June 9, 2014 2:33 PM, bowen zhang <bo...@yahoo.com.INVALID> wrote:
Hi Mohammad,
I saw you wrote the line "factory.close()" in the destroy method of
JPAService.java. I've seen some issues of this line throwing
invalidStateException while there is active transaction happening,
particularly on Windows. Can you tell me how you make sure there is no
active transaction when shutting down oozie? Should this line be
deleted?
Thanks,Bowen
Re: JPAService.destroy() issue
Posted by bowen zhang <bo...@yahoo.com.INVALID>.
Mohammad, there is no code insuring all active transactions are closed.
On Monday, June 9, 2014 2:53 PM, Mohammad Islam <mi...@yahoo.com.INVALID> wrote:
Bowen,
This has been done a long time back. I can't recall the full context.
However, it is better to make sure all transactions are completed before closing it.
Is there a way to do that? This will be a safer approach.
Deleting the line looks little risky. We need to close the factory. right?
Will it keep some resource leaking?
If we can find any references that it is not required, we can delete the line.
Regards,
Mohammad
On Monday, June 9, 2014 2:33 PM, bowen zhang <bo...@yahoo.com.INVALID> wrote:
Hi Mohammad,
I saw you wrote the line "factory.close()" in the destroy method of
JPAService.java. I've seen some issues of this line throwing
invalidStateException while there is active transaction happening,
particularly on Windows. Can you tell me how you make sure there is no
active transaction when shutting down oozie? Should this line be
deleted?
Thanks,Bowen
Re: JPAService.destroy() issue
Posted by Mohammad Islam <mi...@yahoo.com.INVALID>.
Bowen,
This has been done a long time back. I can't recall the full context.
However, it is better to make sure all transactions are completed before closing it.
Is there a way to do that? This will be a safer approach.
Deleting the line looks little risky. We need to close the factory. right?
Will it keep some resource leaking?
If we can find any references that it is not required, we can delete the line.
Regards,
Mohammad
On Monday, June 9, 2014 2:33 PM, bowen zhang <bo...@yahoo.com.INVALID> wrote:
Hi Mohammad,
I saw you wrote the line "factory.close()" in the destroy method of
JPAService.java. I've seen some issues of this line throwing
invalidStateException while there is active transaction happening,
particularly on Windows. Can you tell me how you make sure there is no
active transaction when shutting down oozie? Should this line be
deleted?
Thanks,Bowen