You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@sedona.apache.org by "Kontinuation (via GitHub)" <gi...@apache.org> on 2026/01/22 01:02:40 UTC

[PR] [GH-2396] Making splitting polygon by line robust by removing the computation of line-polygon intersection [sedona]

Kontinuation opened a new pull request, #2598:
URL: https://github.com/apache/sedona/pull/2598

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2396 
   
   ## What changes were proposed in this PR?
   
   This patch fixes splitting a polygon using linestring by porting the corresponding logic from PostGIS. Relevant PostGIS code: https://github.com/postgis/postgis/blob/3.6.1/liblwgeom/lwgeom_geos_split.c#L349-L491
   
   ## How was this patch tested?
   
   Added the case mentioned in the issue as a unit test and pass it.
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-2396] Making splitting polygon by line robust by removing the computation of line-polygon intersection [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.

jiayuasu merged PR #2598:
URL: https://github.com/apache/sedona/pull/2598


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-2396] Making splitting polygon by line robust by removing the computation of line-polygon intersection [sedona]

Posted by "Kontinuation (via GitHub)" <gi...@apache.org>.

Kontinuation commented on PR #2598:
URL: https://github.com/apache/sedona/pull/2598#issuecomment-3782030192

   The Python test failures is likely caused by the [release of Pandas 3.0](https://pandas.pydata.org/docs/dev/whatsnew/v3.0.0.html). I'll fix it in another PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org