[GitHub] nifi-minifi-cpp pull request #199: MINIFICPP-316: Fix GPS tests and resolve ...

[phrocker <gi...@git.apache.org>]

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/199

    MINIFICPP-316: Fix GPS tests and resolve linter error

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-316

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit bc6599563d933d747e4f1c204ee94076394171c1
Author: Marc Parisi <ph...@apache.org>
Date:   2017-11-21T14:22:28Z

    MINIFICPP-316: Fix GPS tests and resolve linter error

----


---

[GitHub] nifi-minifi-cpp issue #199: MINIFICPP-316: Fix GPS tests and resolve linter ...

[apiri <gi...@git.apache.org>]

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/199
  
    reviewing


---

[GitHub] nifi-minifi-cpp pull request #199: MINIFICPP-316: Fix GPS tests and resolve ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/199


---

[GitHub] nifi-minifi-cpp issue #199: MINIFICPP-316: Fix GPS tests and resolve linter ...

[calebj <gi...@git.apache.org>]

Github user calebj commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/199
  
    I'm too late, but removing the `CATCH_CONFIG_MAIN` and linking to `${CATCH_MAIN_LIB}` instead would be mode consistent with the other extensions' test creation script. I'll put that into #168 for now.


---

[GitHub] nifi-minifi-cpp issue #199: MINIFICPP-316: Fix GPS tests and resolve linter ...

[apiri <gi...@git.apache.org>]

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/199
  
    changes look good, will merge


---