You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/14 20:36:12 UTC
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#18056: Fix ci/docker_cache.py
leezu commented on a change in pull request #18056: Fix ci/docker_cache.py
URL: https://github.com/apache/incubator-mxnet/pull/18056#discussion_r408419117
##########
File path: ci/build.py
##########
@@ -71,7 +71,7 @@ def get_docker_binary(use_nvidia_docker: bool) -> str:
def build_docker(platform: str, docker_binary: str, registry: str, num_retries: int, no_cache: bool,
- cache_intermediate: bool) -> str:
+ cache_intermediate: bool = False) -> str:
Review comment:
I don't mind changing it to `True`, but the existing behaviour before introducing the flag was `False`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services