You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pedro-martins <gi...@git.apache.org> on 2015/12/19 19:12:48 UTC

[GitHub] cloudstack pull request: Removed unused variables from class Netwo...

GitHub user pedro-martins opened a pull request:

    https://github.com/apache/cloudstack/pull/1261

    Removed unused variables from class NetworkStateListener

    Removed unused variables from class NetworkStateListener
    
    We removed the following variables from "com.cloud.network.NetworkStateListener"
    . UsageEventDao _usageEventDao
    . NetworkDao _networkDao
    and we changed the EventBus s_eventBus variable to private.
    Also, we change the constructor to not use those variables and apply this change in classes “com.cloud.network.IpAddressManagerImpl” and “org.apache.cloudstack.engine.orchestration.NetworkOrchestrator”

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rafaelweingartner/cloudstack lrg-cs-hackday-19

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1261
    
----
commit 5d3adb3a2da6aea6fba8f563548de14cdcca7625
Author: pedro-martins <ph...@gmail.com>
Date:   2015-12-19T17:54:26Z

    Removed unused variables from class NetworkStateListener

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1261#issuecomment-175688349
  
    LGTM, dead code remove nice :)
    Merging based on 2+LGTMs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1261#issuecomment-175782752
  
    @bhaisaab Why merge without running integration tests? How do we know this doesn't break anything else?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/1261#issuecomment-167047897
  
    Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1261#issuecomment-176045236
  
    @remibergsma build/smoke tests passed, constructor definition was changed with unused variables removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:

    https://github.com/apache/cloudstack/pull/1261#issuecomment-172383990
  
    LGMT. Can I give you a suggestion? You could remove those variable initializing with "_" (underscore) seems that is a common practice in C++ programming.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---