You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/24 13:13:06 UTC
[GitHub] [arrow-datafusion] martin-g opened a new pull request, #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
martin-g opened a new pull request, #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784
Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/2783.
# Rationale for this change
avro_rs has been [donated](https://github.com/flavray/avro-rs/#%EF%B8%8F-avro-rs-is-no-longer-maintained-here-please-refer-to-the-apacheavrorust-repository-instead-make-sure-you-read-the-apache-avro-guidelines-here-%EF%B8%8F) to Apache Avro project.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Yes, some APIs have changed.
Now is the moment to discuss them! But since it will be `0.x` release we could make more breaking changes later too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] martin-g commented on a diff in pull request #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
Posted by GitBox <gi...@apache.org>.
martin-g commented on code in PR #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784#discussion_r906066422
##########
datafusion/common/Cargo.toml:
##########
@@ -33,13 +33,13 @@ name = "datafusion_common"
path = "src/lib.rs"
[features]
-avro = ["avro-rs"]
+avro = ["apache-avro"]
jit = ["cranelift-module"]
pyarrow = ["pyo3"]
[dependencies]
+apache-avro = { git = "https://github.com/apache/avro.git", features = ["snappy"], optional = true }
Review Comment:
Temporarily use Git url until 0.14 is released at https://crates.io (hopefully soon!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] martin-g commented on pull request #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784#issuecomment-1205013151
https://crates.io/crates/apache-avro/0.14.0 has been released!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784#issuecomment-1205764440
Benchmark runs are scheduled for baseline = b2be7abd6fb4154f725cc4235318515f1183619a and contender = 07b7314d8769da3567998b5fa3385c04a645a80d. 07b7314d8769da3567998b5fa3385c04a645a80d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/467082c0bf33428e883b22b6c347cbb2...e4497bf40507475bae7ce4664a647fce/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2d34b2c0a054d16b9ba612232d0dc3a...7b074880c7184140ba76dd1568d4a3a6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e7479fefdfad49bf83320978c4012b07...bee86df4353c47d18011251df0c6741a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/982767821e1441449c44a5f9171693ed...3d78991e83594d9dae11a472626e59d8/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784#issuecomment-1169055921
Nice, looking at the changes in the upstream project, it looks like a lot of improvements have landed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] martin-g commented on a diff in pull request #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
Posted by GitBox <gi...@apache.org>.
martin-g commented on code in PR #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784#discussion_r906052952
##########
datafusion/common/Cargo.toml:
##########
@@ -33,13 +33,14 @@ name = "datafusion_common"
path = "src/lib.rs"
[features]
-avro = ["avro-rs"]
+avro = ["apache-avro"]
jit = ["cranelift-module"]
pyarrow = ["pyo3"]
[dependencies]
+cranelift-module = { version = "0.84.0", optional = true }
+apache-avro = { path = "/home/martin/git/apache/avro/lang/rust/avro", features = ["snappy"], optional = true }
Review Comment:
This is temporary until apache-avro 0.14 is released to https://crates.io (hopefully soon!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2784: Migrate from avro_rs (0.13) to apache_avro (0.14)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2784:
URL: https://github.com/apache/arrow-datafusion/pull/2784#issuecomment-1165619774
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2784](https://codecov.io/gh/apache/arrow-datafusion/pull/2784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2249256) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/aed3aa46d98ed86c296d447ef4de676ea77c62a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aed3aa4) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2784 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 272 272
Lines 48073 48073
=======================================
Hits 40938 40938
Misses 7135 7135
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/common/src/error.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL2Vycm9yLnJz) | `82.27% <ø> (ø)` | |
| [...usion/core/src/avro\_to\_arrow/arrow\_array\_reader.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9hdnJvX3RvX2Fycm93L2Fycm93X2FycmF5X3JlYWRlci5ycw==) | `0.00% <0.00%> (ø)` | |
| [datafusion/core/src/avro\_to\_arrow/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9hdnJvX3RvX2Fycm93L21vZC5ycw==) | `42.85% <0.00%> (ø)` | |
| [datafusion/core/src/avro\_to\_arrow/reader.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9hdnJvX3RvX2Fycm93L3JlYWRlci5ycw==) | `0.00% <ø> (ø)` | |
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `73.91% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2784?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2784?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aed3aa4...2249256](https://codecov.io/gh/apache/arrow-datafusion/pull/2784?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org