You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sh...@apache.org on 2013/10/09 12:34:15 UTC
svn commit: r1530555 - in /lucene/dev/trunk/solr: CHANGES.txt
core/src/java/org/apache/solr/cloud/Overseer.java
Author: shalin
Date: Wed Oct 9 10:34:15 2013
New Revision: 1530555
URL: http://svn.apache.org/r1530555
Log:
SOLR-5321: Remove unnecessary code in Overseer.updateState method which tries to use router name from message where none is ever sent
Modified:
lucene/dev/trunk/solr/CHANGES.txt
lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java
Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1530555&r1=1530554&r2=1530555&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Wed Oct 9 10:34:15 2013
@@ -147,6 +147,9 @@ Other Changes
* SOLR-5319: Remove unused and incorrect router name from Collection ZK nodes.
(Jessica Cheng via shalin)
+* SOLR-5321: Remove unnecessary code in Overseer.updateState method which tries to
+ use router name from message where none is ever sent. (shalin)
+
================== 4.5.0 ==================
Versions of Major Components
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java?rev=1530555&r1=1530554&r2=1530555&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java Wed Oct 9 10:34:15 2013
@@ -308,18 +308,12 @@ public class Overseer {
Integer numShards = message.getInt(ZkStateReader.NUM_SHARDS_PROP, null);
log.info("Update state numShards={} message={}", numShards, message);
- String router = message.getStr(OverseerCollectionProcessor.ROUTER,DocRouter.DEFAULT_NAME);
List<String> shardNames = new ArrayList<String>();
//collection does not yet exist, create placeholders if num shards is specified
boolean collectionExists = state.getCollections().contains(collection);
if (!collectionExists && numShards!=null) {
- if(ImplicitDocRouter.NAME.equals(router)){
- getShardNames(shardNames, message.getStr("shards",null));
- numShards = shardNames.size();
- }else {
- getShardNames(numShards, shardNames);
- }
+ getShardNames(numShards, shardNames);
state = createCollection(state, collection, shardNames, message);
}