You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/08/28 23:53:37 UTC
Review Request 25166: OOZIE-1984 SLACalculator in HA mode performs
duplicate operations on records with completed jobs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25166/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1984
https://issues.apache.org/jira/browse/OOZIE-1984
Repository: oozie-git
Description
-------
see jira
Diffs
-----
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
Diff: https://reviews.apache.org/r/25166/diff/
Testing
-------
existing test pass. e-2-e test will follow in QA
Thanks,
Mona Chitnis
Re: Review Request 25166: OOZIE-1984 SLACalculator in HA mode performs
duplicate operations on records with completed jobs
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25166/#review51844
-----------------------------------------------------------
Ship it!
Ship It!
- Ryota Egashira
On Aug. 28, 2014, 10:55 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25166/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 10:55 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1984
> https://issues.apache.org/jira/browse/OOZIE-1984
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
>
> Diff: https://reviews.apache.org/r/25166/diff/
>
>
> Testing
> -------
>
> existing test pass. e-2-e test will follow in QA
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 25166: OOZIE-1984 SLACalculator in HA mode performs
duplicate operations on records with completed jobs
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25166/
-----------------------------------------------------------
(Updated Aug. 28, 2014, 10:55 p.m.)
Review request for oozie.
Changes
-------
Ryota's comment addressed and after offline clarification
Bugs: OOZIE-1984
https://issues.apache.org/jira/browse/OOZIE-1984
Repository: oozie-git
Description
-------
see jira
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
Diff: https://reviews.apache.org/r/25166/diff/
Testing
-------
existing test pass. e-2-e test will follow in QA
Thanks,
Mona Chitnis
Re: Review Request 25166: OOZIE-1984 SLACalculator in HA mode performs
duplicate operations on records with completed jobs
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25166/#review51842
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/25166/#comment90465>
we can move
slaCalc = new SLACalcStatus(slaSummaryBean, slaRegBean) to inside if-block, to save slacalc instantiate when evenrprocess=7.
then we do not need "slaMap.containsKey(jobId)"
from later if-statement
- Ryota Egashira
On Aug. 28, 2014, 9:53 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25166/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 9:53 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1984
> https://issues.apache.org/jira/browse/OOZIE-1984
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
>
> Diff: https://reviews.apache.org/r/25166/diff/
>
>
> Testing
> -------
>
> existing test pass. e-2-e test will follow in QA
>
>
> Thanks,
>
> Mona Chitnis
>
>