You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/10/19 18:12:56 UTC

[GitHub] rhtyd commented on a change in pull request #2870: KVM HyperV Enlightment for Improved Windows Server 2008+ Performance

rhtyd commented on a change in pull request #2870: KVM HyperV Enlightment for Improved Windows Server 2008+ Performance
URL: https://github.com/apache/cloudstack/pull/2870#discussion_r226737124
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -2016,6 +2016,19 @@ protected void setQuotaAndPeriod(VirtualMachineTO vmTO, CpuTuneDef ctd) {
         }
     }
 
+    protected void enlightenWindowsVm(VirtualMachineTO vmTO, FeaturesDef features) {
+    // If OS is Windows PV, then enable the features. Features supported on Windows 2008 and later
 
 Review comment:
   minor nit - Fix indent of comment to match that of statements inside method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services