You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Akshay Rai <ak...@gmail.com> on 2015/09/03 12:45:52 UTC
Review Request 38088: OOZIE-2346 Add sub-workflow information like the
super-parent id and workflow depth into the 'oozie.job.info' property
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
Review request for oozie and Purshotam Shah.
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 91 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 1689
Tests failed: 3
Tests errors: 0
The patch failed the following testcases:
testHostname(org.apache.oozie.servlet.TestHostnameFilter)
testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The test failures are not related to the fix.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
> On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java, line 189
> > <https://reviews.apache.org/r/38088/diff/5/?file=1068130#file1068130line189>
> >
> > context.getWorkflow().getId() => this should be
> > context.getWorkflow().getParentId()
If you look at the injectParent call just before this, you will see that we are injecting the current workflow id into the subworkflow's configuration. So the current workflow id is the immediate parent id to the subworkflow.
Similarly while injecting the super parent id, the super parent for the subworkflow will be
1. Its immediate parent id, if the subworkflow is at depth 1.
2. Else it will be the super parent id that we injected into the parent conf.
> On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 50
> > <https://reviews.apache.org/r/38088/diff/5/?file=1068129#file1068129line50>
> >
> > wf.superparent.id
I will make this change.
> On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java, line 129
> > <https://reviews.apache.org/r/38088/diff/5/?file=1068130#file1068130line129>
> >
> > I don't think parentConf will ever have SUPER_PARENT_ID. parentConf is jobConf.
When the start method is called(line 155) for a subworkflow at depth 1, the parentConf will not have a super parent id. That is when I will inject the immediate parent id into the subworkflow's job conf as the SUPER_PARENT_ID. So for subworkflows at depth 2 onwards, the SUPER_PARENT_ID will be available in the parentConf.
> On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java, line 186
> > <https://reviews.apache.org/r/38088/diff/5/?file=1068131#file1068131line186>
> >
> > It should be parent id not name.
Will fix this.
> On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 41
> > <https://reviews.apache.org/r/38088/diff/5/?file=1068129#file1068129line41>
> >
> > Why do u need console.url. You can construct it from others properties.
None of the properties in the job conf have the console url.
- Akshay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review99278
-----------------------------------------------------------
On Sept. 11, 2015, 7:07 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 7:07 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
>
> +1 PATCH_APPLIES
> +1 CLEAN
> +1 RAW_PATCH_ANALYSIS
> +1 the patch does not introduce any @author tags
> +1 the patch does not introduce any tabs
> +1 the patch does not introduce any trailing spaces
> +1 the patch does not introduce any line longer than 132
> +1 the patch does adds/modifies 1 testcase(s)
> +1 RAT
> +1 the patch does not seem to introduce new RAT warnings
> +1 JAVADOC
> +1 the patch does not seem to introduce new Javadoc warnings
> WARNING: the current HEAD has 91 Javadoc warning(s)
> +1 COMPILE
> +1 HEAD compiles
> +1 patch compiles
> +1 the patch does not seem to introduce new javac warnings
> +1 BACKWARDS_COMPATIBILITY
> +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
> +1 the patch does not modify JPA files
> -1 TESTS
> Tests run: 1689
> Tests failed: 3
> Tests errors: 0
>
> The patch failed the following testcases:
>
> testHostname(org.apache.oozie.servlet.TestHostnameFilter)
> testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
> testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
>
> +1 DISTRO
> +1 distro tarball builds with the patch
>
> ----------------------------
> -1 Overall result, please check the reported -1(s)
>
>
> The test failures are not related to the fix.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review99278
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java (line 41)
<https://reviews.apache.org/r/38088/#comment156184>
Why do u need console.url. You can construct it from others properties.
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java (line 50)
<https://reviews.apache.org/r/38088/#comment156189>
wf.superparent.id
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java (line 129)
<https://reviews.apache.org/r/38088/#comment156187>
I don't think parentConf will ever have SUPER_PARENT_ID. parentConf is jobConf.
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java (line 189)
<https://reviews.apache.org/r/38088/#comment156186>
context.getWorkflow().getId() => this should be
context.getWorkflow().getParentId()
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java (line 186)
<https://reviews.apache.org/r/38088/#comment156190>
It should be parent id not name.
- Purshotam Shah
On Sept. 11, 2015, 7:07 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 7:07 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
>
> +1 PATCH_APPLIES
> +1 CLEAN
> +1 RAW_PATCH_ANALYSIS
> +1 the patch does not introduce any @author tags
> +1 the patch does not introduce any tabs
> +1 the patch does not introduce any trailing spaces
> +1 the patch does not introduce any line longer than 132
> +1 the patch does adds/modifies 1 testcase(s)
> +1 RAT
> +1 the patch does not seem to introduce new RAT warnings
> +1 JAVADOC
> +1 the patch does not seem to introduce new Javadoc warnings
> WARNING: the current HEAD has 91 Javadoc warning(s)
> +1 COMPILE
> +1 HEAD compiles
> +1 patch compiles
> +1 the patch does not seem to introduce new javac warnings
> +1 BACKWARDS_COMPATIBILITY
> +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
> +1 the patch does not modify JPA files
> -1 TESTS
> Tests run: 1689
> Tests failed: 3
> Tests errors: 0
>
> The patch failed the following testcases:
>
> testHostname(org.apache.oozie.servlet.TestHostnameFilter)
> testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
> testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
>
> +1 DISTRO
> +1 distro tarball builds with the patch
>
> ----------------------------
> -1 Overall result, please check the reported -1(s)
>
>
> The test failures are not related to the fix.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On Oct. 5, 2015, 9:15 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 106
> > <https://reviews.apache.org/r/38088/diff/8/?file=1088413#file1088413line106>
> >
> > Why are you adding CONSOLE_URL? I don't see any use of adding static CONSOLE_URL for each job.
>
> Akshay Rai wrote:
> Firstly, schedulers like azkaban inject the completet url of the job into the conf.
>
> For a job scheduled on oozie it is not possible to get the link to the job unless we know the console url.
>
> In the oozie-default.xml file there is a property 'oozie.JobCommand.job.console.url' which holds the base console url for a worklfow job but this isn't injected into the job conf.
>
> Purshotam Shah wrote:
> Your console URL will look like "http://host:port/proxy/application_1444287091929_370807/".
> From job conf you can get "mapreduce.jobtracker.address" and and construct console url.
> We will be setting ooozie job info to job conf. Don't u think that it will be duplicate entry.
> I am just try to avoid duplicate entries ( if we can compute it somwhow).
>
> Akshay Rai wrote:
> Sorry for the delay. I really don't know why I am not receiving any email notifications for any updates on my rb apart from myself even after enabling it.
>
> Anyway, coming back to the topic, I am afraid there is some misunderstanding here. The console url I am referring to is the oozie job console url which looks like this http://localhost:11000/oozie?job=0000217-150708230502772-oozie-oozi-W
>
> A snapshot from oozie-default.xml
>
> ```html
> <property>
> <name>oozie.JobCommand.job.console.url</name>
> <value>${oozie.base.url}?job=</value>
> </property>
>
> <property>
> <name>oozie.base.url</name>
> <value>http://localhost:11000/oozie</value>
> <description>
> Base Oozie URL.
> </description>
> </property>
> ```
>
> To construct this url there is no property in the job conf which can be used.
>
> Now, there are 2 ways of injecting this info
> 1. Inject the complete oozie job url like the one I mentioned in the above para into the job conf. But there is a problem with this approach. That is, to maintain consistency we may have to inject the complete url to the super parent and the coordinator as well which seems like many duplicates.
> 2. Inject only the base console url separately. Now using this base console url and the ids to the job, super parent and coordinator, the complete urls can be constructed.
You can get base.url from job.end-notification.url.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review101532
-----------------------------------------------------------
On Oct. 19, 2015, 6:50 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 6:50 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
> On Oct. 5, 2015, 9:15 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 106
> > <https://reviews.apache.org/r/38088/diff/8/?file=1088413#file1088413line106>
> >
> > Why are you adding CONSOLE_URL? I don't see any use of adding static CONSOLE_URL for each job.
>
> Akshay Rai wrote:
> Firstly, schedulers like azkaban inject the completet url of the job into the conf.
>
> For a job scheduled on oozie it is not possible to get the link to the job unless we know the console url.
>
> In the oozie-default.xml file there is a property 'oozie.JobCommand.job.console.url' which holds the base console url for a worklfow job but this isn't injected into the job conf.
>
> Purshotam Shah wrote:
> Your console URL will look like "http://host:port/proxy/application_1444287091929_370807/".
> From job conf you can get "mapreduce.jobtracker.address" and and construct console url.
> We will be setting ooozie job info to job conf. Don't u think that it will be duplicate entry.
> I am just try to avoid duplicate entries ( if we can compute it somwhow).
>
> Akshay Rai wrote:
> Sorry for the delay. I really don't know why I am not receiving any email notifications for any updates on my rb apart from myself even after enabling it.
>
> Anyway, coming back to the topic, I am afraid there is some misunderstanding here. The console url I am referring to is the oozie job console url which looks like this http://localhost:11000/oozie?job=0000217-150708230502772-oozie-oozi-W
>
> A snapshot from oozie-default.xml
>
> ```html
> <property>
> <name>oozie.JobCommand.job.console.url</name>
> <value>${oozie.base.url}?job=</value>
> </property>
>
> <property>
> <name>oozie.base.url</name>
> <value>http://localhost:11000/oozie</value>
> <description>
> Base Oozie URL.
> </description>
> </property>
> ```
>
> To construct this url there is no property in the job conf which can be used.
>
> Now, there are 2 ways of injecting this info
> 1. Inject the complete oozie job url like the one I mentioned in the above para into the job conf. But there is a problem with this approach. That is, to maintain consistency we may have to inject the complete url to the super parent and the coordinator as well which seems like many duplicates.
> 2. Inject only the base console url separately. Now using this base console url and the ids to the job, super parent and coordinator, the complete urls can be constructed.
>
> Purshotam Shah wrote:
> You can get base.url from job.end-notification.url.
Thanks, you are right. I think we can construct the console url from the callback url.
Strangely, the mapreduce.job.end-notification.url is not injected into the job conf. I will update a fix for this in this rb.
- Akshay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review101532
-----------------------------------------------------------
On Oct. 19, 2015, 6:50 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 6:50 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
On Oct. 5, 2015, 9:15 p.m., Akshay Rai wrote:
> > minor comment... Rest looks good. Remove CONSOLE_URL.
>
> Akshay Rai wrote:
> Thanks Purshotam for the review.
>
> I have one question. I see that the coordinator Id also needs a change as it doesn't inject the right coord id for a subworkflow. Shall I make the change in the same rb or should I create a separate one?
As per your email response, I have made the change in the same rb.
- Akshay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review101532
-----------------------------------------------------------
On Oct. 19, 2015, 6:50 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 6:50 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
> On Oct. 5, 2015, 9:15 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 106
> > <https://reviews.apache.org/r/38088/diff/8/?file=1088413#file1088413line106>
> >
> > Why are you adding CONSOLE_URL? I don't see any use of adding static CONSOLE_URL for each job.
>
> Akshay Rai wrote:
> Firstly, schedulers like azkaban inject the completet url of the job into the conf.
>
> For a job scheduled on oozie it is not possible to get the link to the job unless we know the console url.
>
> In the oozie-default.xml file there is a property 'oozie.JobCommand.job.console.url' which holds the base console url for a worklfow job but this isn't injected into the job conf.
>
> Purshotam Shah wrote:
> Your console URL will look like "http://host:port/proxy/application_1444287091929_370807/".
> From job conf you can get "mapreduce.jobtracker.address" and and construct console url.
> We will be setting ooozie job info to job conf. Don't u think that it will be duplicate entry.
> I am just try to avoid duplicate entries ( if we can compute it somwhow).
Sorry for the delay. I really don't know why I am not receiving any email notifications for any updates on my rb apart from myself even after enabling it.
Anyway, coming back to the topic, I am afraid there is some misunderstanding here. The console url I am referring to is the oozie job console url which looks like this http://localhost:11000/oozie?job=0000217-150708230502772-oozie-oozi-W
A snapshot from oozie-default.xml
```html
<property>
<name>oozie.JobCommand.job.console.url</name>
<value>${oozie.base.url}?job=</value>
</property>
<property>
<name>oozie.base.url</name>
<value>http://localhost:11000/oozie</value>
<description>
Base Oozie URL.
</description>
</property>
```
To construct this url there is no property in the job conf which can be used.
Now, there are 2 ways of injecting this info
1. Inject the complete oozie job url like the one I mentioned in the above para into the job conf. But there is a problem with this approach. That is, to maintain consistency we may have to inject the complete url to the super parent and the coordinator as well which seems like many duplicates.
2. Inject only the base console url separately. Now using this base console url and the ids to the job, super parent and coordinator, the complete urls can be constructed.
- Akshay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review101532
-----------------------------------------------------------
On Oct. 19, 2015, 6:50 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 6:50 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
> On Oct. 5, 2015, 9:15 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 106
> > <https://reviews.apache.org/r/38088/diff/8/?file=1088413#file1088413line106>
> >
> > Why are you adding CONSOLE_URL? I don't see any use of adding static CONSOLE_URL for each job.
Firstly, schedulers like azkaban inject the completet url of the job into the conf.
For a job scheduled on oozie it is not possible to get the link to the job unless we know the console url.
In the oozie-default.xml file there is a property 'oozie.JobCommand.job.console.url' which holds the base console url for a worklfow job but this isn't injected into the job conf.
On Oct. 5, 2015, 9:15 p.m., Akshay Rai wrote:
> > minor comment... Rest looks good. Remove CONSOLE_URL.
Thanks Purshotam for the review.
I have one question. I see that the coordinator Id also needs a change as it doesn't inject the right coord id for a subworkflow. Shall I make the change in the same rb or should I create a separate one?
- Akshay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review101532
-----------------------------------------------------------
On Oct. 1, 2015, 4:54 p.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 4:54 p.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On Oct. 5, 2015, 9:15 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 106
> > <https://reviews.apache.org/r/38088/diff/8/?file=1088413#file1088413line106>
> >
> > Why are you adding CONSOLE_URL? I don't see any use of adding static CONSOLE_URL for each job.
>
> Akshay Rai wrote:
> Firstly, schedulers like azkaban inject the completet url of the job into the conf.
>
> For a job scheduled on oozie it is not possible to get the link to the job unless we know the console url.
>
> In the oozie-default.xml file there is a property 'oozie.JobCommand.job.console.url' which holds the base console url for a worklfow job but this isn't injected into the job conf.
Your console URL will look like "http://host:port/proxy/application_1444287091929_370807/".
>From job conf you can get "mapreduce.jobtracker.address" and and construct console url.
We will be setting ooozie job info to job conf. Don't u think that it will be duplicate entry.
I am just try to avoid duplicate entries ( if we can compute it somwhow).
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review101532
-----------------------------------------------------------
On Oct. 19, 2015, 6:50 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 6:50 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review101532
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java (line 106)
<https://reviews.apache.org/r/38088/#comment158948>
Why are you adding CONSOLE_URL? I don't see any use of adding static CONSOLE_URL for each job.
minor comment... Rest looks good. Remove CONSOLE_URL.
- Purshotam Shah
On Oct. 1, 2015, 4:54 p.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 4:54 p.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/#review104616
-----------------------------------------------------------
Ship it!
Ship It!
- Purshotam Shah
On Oct. 28, 2015, 11:46 a.m., Akshay Rai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38088/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 11:46 a.m.)
>
>
> Review request for oozie, Purshotam Shah and Robert Kanter.
>
>
> Bugs: OOZIE-2346
> https://issues.apache.org/jira/browse/OOZIE-2346
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add super parent id and workflow depth information along with the other oozie job information into the job conf.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java e83b3b5
> core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java ada8a30
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
>
> Diff: https://reviews.apache.org/r/38088/diff/
>
>
> Testing
> -------
>
> Tested locally by running a subworkflow with and without a coordinator.
>
>
> Thanks,
>
> Akshay Rai
>
>
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 11:46 a.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
- Removed console url from the test case.
- Updated test.
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java e83b3b5
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java ada8a30
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Tested locally by running a subworkflow with and without a coordinator.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 6:31 a.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
- Fix for injecting callback url to job conf.
- Removed console url as it can be now constructed from the job.end-notification.url
Tested on local deployment
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 0ea2eea
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Tested locally by running a subworkflow with and without a coordinator.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 6:50 a.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
Changes:
- Injecting the right coordinator Id for sub-workflows into the job conf.
- Propagate coordinator and bundle info to the subworkflow conf.
Tested locally.
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Tested locally by running a subworkflow with and without a coordinator.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Oct. 1, 2015, 4:54 p.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
* Updated the comments
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Tested locally by running a subworkflow with and without a coordinator.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 12:16 p.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
Changes:
- Super parent id for a worklflow submitted by a coordinator should be the coordinator id rather than the workflow id.
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2
core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing (updated)
-------
Tested locally by running a subworkflow with and without a coordinator.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 6:33 a.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
Addressed Purshotam's comments
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 91 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 1689
Tests failed: 3
Tests errors: 0
The patch failed the following testcases:
testHostname(org.apache.oozie.servlet.TestHostnameFilter)
testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The test failures are not related to the fix.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 7:07 a.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
I think it makes sense to inject the base console url rather than the complete url.
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 91 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 1689
Tests failed: 3
Tests errors: 0
The patch failed the following testcases:
testHostname(org.apache.oozie.servlet.TestHostnameFilter)
testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The test failures are not related to the fix.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 12:56 p.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
Minor correction
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 91 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 1689
Tests failed: 3
Tests errors: 0
The patch failed the following testcases:
testHostname(org.apache.oozie.servlet.TestHostnameFilter)
testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The test failures are not related to the fix.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 12:50 p.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
Added oozie job console url to the test
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 91 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 1689
Tests failed: 3
Tests errors: 0
The patch failed the following testcases:
testHostname(org.apache.oozie.servlet.TestHostnameFilter)
testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The test failures are not related to the fix.
Thanks,
Akshay Rai
Re: Review Request 38088: OOZIE-2346 Add sub-workflow information
like the
super-parent id and workflow depth into the 'oozie.job.info' property
Posted by Akshay Rai <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38088/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 12:36 p.m.)
Review request for oozie, Purshotam Shah and Robert Kanter.
Changes
-------
Added Oozie job console url to the list.
Bugs: OOZIE-2346
https://issues.apache.org/jira/browse/OOZIE-2346
Repository: oozie-git
Description
-------
Add super parent id and workflow depth information along with the other oozie job information into the job conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java ceaef8b
Diff: https://reviews.apache.org/r/38088/diff/
Testing
-------
Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 --reset-scm
+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 91 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 1689
Tests failed: 3
Tests errors: 0
The patch failed the following testcases:
testHostname(org.apache.oozie.servlet.TestHostnameFilter)
testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The test failures are not related to the fix.
Thanks,
Akshay Rai