You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2012/09/11 16:38:36 UTC
Re: Review Request: This bug fix adds new rows in the template_zone_ref
rather than changing the removed column in the existing entries which
correspond to previous deletions of the same template.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/
-----------------------------------------------------------
(Updated Sept. 11, 2012, 2:38 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Sumarry of changes:
Changed the function addTemplateToZone VMTemplateDaoImpl.java.
This was needed as the previous version tried to update the removed column of the row in template_zone_ref table in database.
The removed column cannot be updated once it is set to some value other than NULL (i.e. a time stamp which tell when the template was removed).
This caused the recopying of the template (After deleting it once ) to fail. So now we add a new row while recopying the template if it dose
not exist and update the time and date in the database if it exists already.
Changed the copy function and the copyTemplate function in TemplateManagerImpl.java.
This file now has a check to avoid copying of template even if there is one already in the zone and it re initiates the copy job if the
user tries to recopy the template again while it is in error state and does not do anything if the template is already downloaded or is
being downloaded.
Changed the delete function in HyervisorTemplateAdapter.java file.
It uses the findByZoneTemplate function in the delete function to remove the template. This function fetches any entry which matches
the template id and the zone id, It dose not check for the value of the removed column. So we have used a function listByZoneTemplate
which retrieves only the rows where templateid, zoneid, and removed is equal to NULL match. (Note that at any time we can have only
one row which matches the above mentioned criteria.) As a result it dose not update the rows where removed is not NULL i.e. entries
corresponding to earlier deletions of the same template.
Summary (updated)
-----------------
This bug fix adds new rows in the template_zone_ref rather than changing the removed column in the existing entries which correspond to previous deletions of the same template.
Description
-------
This bug fix (CS-14673) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
Diffs
-----
server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
Diff: https://reviews.apache.org/r/7018/diff/
Testing
-------
I have tested this on the asf branch.
Thanks,
bharat kumar
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review11381
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On Sept. 11, 2012, 2:41 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2012, 2:41 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CS-14673) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review18937
-----------------------------------------------------------
Hey Bharat, I tried to apply your patch, it failed. Pl. upload a new git formatted patch, let's apply and close this review.
Cheers.
- Rohit Yadav
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by Rohit Yadav <bh...@apache.org>.
> On Jan. 13, 2013, 5:15 p.m., bharat kumar wrote:
> > Ship It!
Bharat, your reviewers should ship it and when they do that they should commit your patch.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review15304
-----------------------------------------------------------
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
RE: Review Request: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Animesh Chaturvedi <an...@citrix.com>.
Nitin this has been pending on you for a long time. Please help close the review
> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Friday, February 15, 2013 9:57 AM
> To: cloudstack-dev@incubator.apache.org; Rohit Yadav; Nitin Mehta
> Cc: Bharat Kumar; Abhinandan Prateek
> Subject: RE: Review Request: when a template is deleted and then copied
> over again , it is still marked as "Removed" in template_zone_ref table.
>
> Nitin
>
> Any updates? Please commit the patch if satisfied.
>
> Animesh
>
> > -----Original Message-----
> > From: Rohit Yadav [mailto:noreply@reviews.apache.org] On Behalf Of
> > Rohit Yadav
> > Sent: Thursday, January 31, 2013 2:13 PM
> > To: Nitin Mehta
> > Cc: cloudstack; Bharat Kumar; Rohit Yadav
> > Subject: Re: Review Request: when a template is deleted and then
> > copied over again , it is still marked as "Removed" in template_zone_ref
> table.
> >
> >
> >
> > > On Jan. 13, 2013, 5:15 p.m., bharat kumar wrote:
> > > > Ship It!
> > >
> > > Rohit Yadav wrote:
> > > Bharat, your reviewers should ship it and when they do that they
> > > should
> > commit your patch.
> >
> > Nitin you gave it a ship it, can you verify the patch in current
> > context and it's shippable give it a ship it, I can help commit it.
> >
> >
> > - Rohit
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/7018/#review15304
> > -----------------------------------------------------------
> >
> >
> > On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/7018/
> > > -----------------------------------------------------------
> > >
> > > (Updated Jan. 13, 2013, 5:14 p.m.)
> > >
> > >
> > > Review request for cloudstack and Nitin Mehta.
> > >
> > >
> > > Description
> > > -------
> > >
> > > This bug fix (CLOUDSTACK-970) deals with the database aspects of
> > > template
> > creation, this changes the way in which the entries are added and
> > removed from template_zone_ref and template_host_ref.
> > >
> > >
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> > > server/src/com/cloud/template/HyervisorTemplateAdapter.java
> bdb89f6
> > > server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
> > >
> > > Diff: https://reviews.apache.org/r/7018/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > I have tested this on the asf branch.
> > >
> > >
> > > Thanks,
> > >
> > > bharat kumar
> > >
> > >
RE: Review Request: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Animesh Chaturvedi <an...@citrix.com>.
Nitin
Any updates? Please commit the patch if satisfied.
Animesh
> -----Original Message-----
> From: Rohit Yadav [mailto:noreply@reviews.apache.org] On Behalf Of Rohit
> Yadav
> Sent: Thursday, January 31, 2013 2:13 PM
> To: Nitin Mehta
> Cc: cloudstack; Bharat Kumar; Rohit Yadav
> Subject: Re: Review Request: when a template is deleted and then copied over
> again , it is still marked as "Removed" in template_zone_ref table.
>
>
>
> > On Jan. 13, 2013, 5:15 p.m., bharat kumar wrote:
> > > Ship It!
> >
> > Rohit Yadav wrote:
> > Bharat, your reviewers should ship it and when they do that they should
> commit your patch.
>
> Nitin you gave it a ship it, can you verify the patch in current context and it's
> shippable give it a ship it, I can help commit it.
>
>
> - Rohit
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/#review15304
> -----------------------------------------------------------
>
>
> On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/7018/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 13, 2013, 5:14 p.m.)
> >
> >
> > Review request for cloudstack and Nitin Mehta.
> >
> >
> > Description
> > -------
> >
> > This bug fix (CLOUDSTACK-970) deals with the database aspects of template
> creation, this changes the way in which the entries are added and removed
> from template_zone_ref and template_host_ref.
> >
> >
> >
> >
> > Diffs
> > -----
> >
> > server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> > server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> > server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
> >
> > Diff: https://reviews.apache.org/r/7018/diff/
> >
> >
> > Testing
> > -------
> >
> > I have tested this on the asf branch.
> >
> >
> > Thanks,
> >
> > bharat kumar
> >
> >
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by Rohit Yadav <bh...@apache.org>.
> On Jan. 13, 2013, 5:15 p.m., bharat kumar wrote:
> > Ship It!
>
> Rohit Yadav wrote:
> Bharat, your reviewers should ship it and when they do that they should commit your patch.
Nitin you gave it a ship it, can you verify the patch in current context and it's shippable give it a ship it, I can help commit it.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review15304
-----------------------------------------------------------
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review15304
-----------------------------------------------------------
Ship it!
Ship It!
- bharat kumar
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review15303
-----------------------------------------------------------
Ship it!
Ship It!
- bharat kumar
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 7018: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On June 30, 2013, 6:05 a.m., Prasanna Santhanam wrote:
> > Don't think this is applicable anymore with the storage subsystem changes.
Bharat can you check on this patch
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review22575
-----------------------------------------------------------
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 7018: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review22575
-----------------------------------------------------------
Don't think this is applicable anymore with the storage subsystem changes.
- Prasanna Santhanam
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Nitin Mehta <Ni...@citrix.com>.
Bharat - Can you please rebase and resend please ?
On 21/03/13 11:10 AM, "Nitin Mehta" <Ni...@citrix.com> wrote:
>Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply
>CS-14673.patch
>CS-14673.patch:19: trailing whitespace.
>
>CS-14673.patch:22: trailing whitespace.
>
>error: patch failed:
>server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java:109
>error: server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java: patch
>does not apply
>error: server/src/com/cloud/template/HyervisorTemplateAdapter.java: No
>such file or directory
>error: patch failed:
>server/src/com/cloud/template/TemplateManagerImpl.java:843
>error: server/src/com/cloud/template/TemplateManagerImpl.java: patch does
>not apply
>
>
>From: Animesh Chaturvedi
><An...@citrix.com>>
>Reply-To: Animesh Chaturvedi
><an...@citrix.com>>
>Date: Wednesday 20 March 2013 10:26 PM
>To: Nitin Mehta <ni...@citrix.com>>
>Cc: Animesh Chaturvedi
><an...@citrix.com>>,
>Bharat Kumar <bh...@citrix.com>>,
>"cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apach
>e.org>"
><cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apach
>e.org>>
>Subject: Re: Review Request: when a template is deleted and then copied
>over again , it is still marked as "Removed" in template_zone_ref table.
>
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/7018/
>
>
>On February 28th, 2013, 2:20 a.m., Nitin Mehta wrote:
>
>Ship It!
>
>Nitin please apply the patch
>
>
>- Animesh
>
>
>On January 13th, 2013, 5:14 p.m., bharat kumar wrote:
>
>Review request for cloudstack and Nitin Mehta.
>By bharat kumar.
>
>Updated Jan. 13, 2013, 5:14 p.m.
>
>Description
>
>This bug fix (CLOUDSTACK-970) deals with the database aspects of template
>creation, this changes the way in which the entries are added and removed
>from template_zone_ref and template_host_ref.
>
>
>
>
>Testing
>
>I have tested this on the asf branch.
>
>
>Diffs
>
> * server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java (2a0dfc8)
> * server/src/com/cloud/template/HyervisorTemplateAdapter.java
>(bdb89f6)
> * server/src/com/cloud/template/TemplateManagerImpl.java (1e87de2)
>
>View Diff<https://reviews.apache.org/r/7018/diff/>
>
Re: Review Request: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Nitin Mehta <Ni...@citrix.com>.
Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply CS-14673.patch
CS-14673.patch:19: trailing whitespace.
CS-14673.patch:22: trailing whitespace.
error: patch failed: server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java:109
error: server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java: patch does not apply
error: server/src/com/cloud/template/HyervisorTemplateAdapter.java: No such file or directory
error: patch failed: server/src/com/cloud/template/TemplateManagerImpl.java:843
error: server/src/com/cloud/template/TemplateManagerImpl.java: patch does not apply
From: Animesh Chaturvedi <An...@citrix.com>>
Reply-To: Animesh Chaturvedi <an...@citrix.com>>
Date: Wednesday 20 March 2013 10:26 PM
To: Nitin Mehta <ni...@citrix.com>>
Cc: Animesh Chaturvedi <an...@citrix.com>>, Bharat Kumar <bh...@citrix.com>>, "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>
Subject: Re: Review Request: when a template is deleted and then copied over again , it is still marked as "Removed" in template_zone_ref table.
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7018/
On February 28th, 2013, 2:20 a.m., Nitin Mehta wrote:
Ship It!
Nitin please apply the patch
- Animesh
On January 13th, 2013, 5:14 p.m., bharat kumar wrote:
Review request for cloudstack and Nitin Mehta.
By bharat kumar.
Updated Jan. 13, 2013, 5:14 p.m.
Description
This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
Testing
I have tested this on the asf branch.
Diffs
* server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java (2a0dfc8)
* server/src/com/cloud/template/HyervisorTemplateAdapter.java (bdb89f6)
* server/src/com/cloud/template/TemplateManagerImpl.java (1e87de2)
View Diff<https://reviews.apache.org/r/7018/diff/>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On Feb. 28, 2013, 2:20 a.m., Nitin Mehta wrote:
> > Ship It!
Nitin please apply the patch
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review17183
-----------------------------------------------------------
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Nitin Mehta <Ni...@citrix.com>.
Bharat – can you please fix the issues and resend it please ?
Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply --whitespace=fix ../CS-14673.patch
../CS-14673.patch:19: trailing whitespace.
../CS-14673.patch:22: trailing whitespace.
error: patch failed: server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java:109
error: server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java: patch does not apply
error: patch failed: server/src/com/cloud/template/HyervisorTemplateAdapter.java:219
error: server/src/com/cloud/template/HyervisorTemplateAdapter.java: patch does not apply
error: patch failed: server/src/com/cloud/template/TemplateManagerImpl.java:843
error: server/src/com/cloud/template/TemplateManagerImpl.java: patch does not apply
From: Nitin Mehta <ni...@citrix.com>>
Reply-To: Nitin Mehta <ni...@citrix.com>>
To: Nitin Mehta <ni...@citrix.com>>
Cc: "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>, Bharat Kumar <bh...@citrix.com>>
Subject: Re: Review Request: when a template is deleted and then copied over again , it is still marked as "Removed" in template_zone_ref table.
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7018/
Ship it!
Ship It!
- Nitin
On January 13th, 2013, 5:14 p.m., bharat kumar wrote:
Review request for cloudstack and Nitin Mehta.
By bharat kumar.
Updated Jan. 13, 2013, 5:14 p.m.
Description
This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
Testing
I have tested this on the asf branch.
Diffs
* server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java (2a0dfc8)
* server/src/com/cloud/template/HyervisorTemplateAdapter.java (bdb89f6)
* server/src/com/cloud/template/TemplateManagerImpl.java (1e87de2)
View Diff<https://reviews.apache.org/r/7018/diff/>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review17183
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 5:14 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/
-----------------------------------------------------------
(Updated Jan. 13, 2013, 5:14 p.m.)
Review request for cloudstack and Nitin Mehta.
Description
-------
This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
Diffs
-----
server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
Diff: https://reviews.apache.org/r/7018/diff/
Testing
-------
I have tested this on the asf branch.
Thanks,
bharat kumar
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/
-----------------------------------------------------------
(Updated Jan. 13, 2013, 5:14 p.m.)
Review request for cloudstack and Nitin Mehta.
Description (updated)
-------
This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
Diffs
-----
server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
Diff: https://reviews.apache.org/r/7018/diff/
Testing
-------
I have tested this on the asf branch.
Thanks,
bharat kumar
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review15302
-----------------------------------------------------------
It doesn't appear that this was committed.
Additionally, your description above refers to a deprecated bug tracker. Please create a bug for this issues at issues.a.o/jira
- David Nalley
On Sept. 11, 2012, 2:41 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2012, 2:41 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CS-14673) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review14755
-----------------------------------------------------------
Was this code applied on master? Pl. check and close the review.
- Rohit Yadav
On Sept. 11, 2012, 2:41 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2012, 2:41 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> This bug fix (CS-14673) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
>
>
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
>
> Diff: https://reviews.apache.org/r/7018/diff/
>
>
> Testing
> -------
>
> I have tested this on the asf branch.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: when a template is deleted and then copied over again ,
it is still marked as "Removed" in template_zone_ref table.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/
-----------------------------------------------------------
(Updated Sept. 11, 2012, 2:41 p.m.)
Review request for cloudstack and Nitin Mehta.
Summary (updated)
-----------------
when a template is deleted and then copied over again , it is still marked as "Removed" in template_zone_ref table.
Description
-------
This bug fix (CS-14673) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref.
Diffs
-----
server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
Diff: https://reviews.apache.org/r/7018/diff/
Testing
-------
I have tested this on the asf branch.
Thanks,
bharat kumar