You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/05/15 04:28:35 UTC

Review Request 34254: Configs: notes don't change if you navigate away

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34254/
-----------------------------------------------------------

Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-11153
    https://issues.apache.org/jira/browse/AMBARI-11153


Repository: ambari


Description
-------

Clean up naming confusion. serviceConfigVersionNote is the only note attribute in MainServiceInfoConfigsController.


Diffs
-----

  ambari-web/app/mixins/common/configs/configs_saver.js 816af7a 
  ambari-web/app/views/common/configs/config_history_flow.js 0e4c07b 

Diff: https://reviews.apache.org/r/34254/diff/


Testing
-------

Manually tested on live cluster.


Thanks,

Richard Zang

Re: Review Request 34254: Configs: notes don't change if you navigate away

Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34254/#review83970
-----------------------------------------------------------

Ship it!


Ship It!

- Srimanth Gunturi


On May 15, 2015, 2:28 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34254/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 2:28 a.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-11153
>     https://issues.apache.org/jira/browse/AMBARI-11153
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clean up naming confusion. serviceConfigVersionNote is the only note attribute in MainServiceInfoConfigsController.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mixins/common/configs/configs_saver.js 816af7a 
>   ambari-web/app/views/common/configs/config_history_flow.js 0e4c07b 
> 
> Diff: https://reviews.apache.org/r/34254/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>