[GitHub] [flink] mchro opened a new pull request #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send()

[GitBox <gi...@apache.org>]

mchro opened a new pull request #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send()
URL: https://github.com/apache/flink/pull/10339
 
 
   ## What is the purpose of the change
   
   https://github.com/apache/flink/pull/8967 changed the Cassandra connector to catch `Exception` and release the semaphore correctly, however this is not general enough as e.g. `Error` can still lead to deadlock. Change code to catch all `Throwable` instead.
   
   
   ## Brief change log
   
     - Release Semaphore correctly on all Throwable in send()
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - Added unit test that validates semaphore released if `Error` in send(); test fails before change.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services