[GitHub] [maven-fluido-skin] rmannibucau commented on pull request #32: Mskins 191 dynamic library retrieval

[GitBox <gi...@apache.org>]

rmannibucau commented on PR #32:
URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147111762

   Some comments because I think the issue is legitimate and we are very 'back' on the frontend deliveries for now.
   
   Maybe using download maven plugin or equivalent to grab the resources from a CDN can be sufficient for now but I think we should consider:
   
   1. NOT packagng the resources in the jar, in particular because we don't own them and we should and will need to upgrade for various reasons (starting by the fact these versions are no more supported and have vulnerabilities)
   2. use node to handle the minification instead of a plugin which does not handle some optimizations of modern web (using browserify at least) sounds like a very good choice for the final delivery so can be worth keeping frontend plugin
   3. (optional) enable to use CDN in the theme which would be probably the best option for most people anyway
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org