You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/01 20:03:38 UTC

[GitHub] [superset] ktmud edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript

ktmud edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-788232044


   @michael-s-molina Did you run `npm install` or was your `superset-ui/chart-controls` linked to a different version? CI didn't catch it because it was actually working? 
   
   I'm pretty sure this was updated here:  https://github.com/apache-superset/superset-ui/pull/962/files#diff-efc1b32a915b3738e7689b97eab6576ac7b206bc95d46e1ecaac6c8646287a65R27 
   
   The `superset-ui` change was supposed to be added in this PR but [another PR](https://github.com/apache/superset/pull/13210) has upgraded them anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org