[GitHub] [hudi] leesf commented on a change in pull request #3079: [HUDI-2013] Removed option to fallback to file listing when Metadata Table is enabled.

[GitBox <gi...@apache.org>]

leesf commented on a change in pull request #3079:
URL: https://github.com/apache/hudi/pull/3079#discussion_r651556052



##########
File path: hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
##########
@@ -101,11 +101,7 @@ protected BaseTableMetadata(HoodieEngineContext engineContext, HoodieMetadataCon
       try {
         return fetchAllPartitionPaths();
       } catch (Exception e) {
-        if (metadataConfig.enableFallback()) {
-          LOG.error("Failed to retrieve list of partition from metadata", e);
-        } else {
-          throw new HoodieMetadataException("Failed to retrieve list of partition from metadata", e);
-        }
+        throw new HoodieMetadataException("Failed to retrieve list of partition from metadata", e);

Review comment:
       remove enable fallback and throw the exception here is to make the metadata table sync fast fail?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org