You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2026/09/14 17:30:46 UTC
[PR] test(bindings/python): respect empty-write capability in writer tests [opendal]
Xuanwo opened a new pull request, #8301:
URL: https://github.com/apache/opendal/pull/8301
# Which issue does this PR close?
Related to #8266; follows up on the tests added in #8300.
# Rationale for this change
`test_sync_writer_preserves_bytes_only_input` rejects every input and then closes an empty writer. On Azfile, which does not advertise `write_can_empty`, the reported behavior test fails during context-manager exit with `PutRange: InvalidHeaderValue`. The input-type check unintentionally requires empty-file support.
# What changes are included in this PR?
Write valid, nonempty bytes after checking the rejected input types, then verify the persisted content. In the owned-buffer test, skip only the all-empty size case when the service lacks `write_can_empty`.
Validation with the current Python binding: the filesystem write suite passed 40 tests; with `write_can_empty=false`, the affected cases passed 17 tests and skipped the four empty-file combinations. The Azure failure was supplied by the maintainer; Azure was not rerun locally because credentials were unavailable.
# Are there any user-facing changes?
No. This changes Python behavior tests only.
# Breaking changes
# AI Usage Statement
- Harness: Codex desktop; model: `gpt-6-astra`; effort: `high`.
- Role: Investigated the maintainer-provided failure, updated the tests, ran local validation, and prepared this PR under the maintainer's direction and approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(bindings/python): respect empty-write capability in writer tests [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #8301:
URL: https://github.com/apache/opendal/pull/8301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org