You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ankitsultana (via GitHub)" <gi...@apache.org> on 2023/06/14 00:24:28 UTC
[GitHub] [pinot] ankitsultana opened a new issue, #10910: Flaky Test PinotFSSegmentUploaderTest
ankitsultana opened a new issue, #10910:
URL: https://github.com/apache/pinot/issues/10910
Saw this in my PR: https://github.com/apache/pinot/actions/runs/5261333672/jobs/9509328866?pr=10895
```
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.922 s - in org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest
[INFO] org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest.testBuildCache Time elapsed: 1.201 s
[INFO] org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest.testCreateRateLimiter Time elapsed: 0.007 s
[INFO] org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest.testMetricEmitter Time elapsed: 0.173 s
[INFO] Running org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest
Error: OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
00:17:05.037 ERROR [PinotFSSegmentUploader] [main] Missing segment store uri. Failed to upload segment file ca980508-3706-464a-be4b-61911ea87e60 for test_REALTIME__1__0__20230614T0017Z.
00:17:05.161 WARN [PinotFSSegmentUploader] [main] Timed out waiting to upload segment: test_REALTIME__1__0__20230614T0017Z for table: test
00:17:05.296 WARN [PinotFSSegmentUploader] [main] Timed out waiting to upload segment: test_REALTIME__1__0__20230614T0017Z for table: test
Error: Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.286 s <<< FAILURE! - in org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest
Error: org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest.testNoSegmentStoreConfigured Time elapsed: 0.01 s
Error: org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest.testSegmentAlreadyExist Time elapsed: 0.132 s <<< FAILURE!
java.lang.NullPointerException: Cannot invoke "java.net.URI.toString()" because "segmentURI" is null
at org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest.testSegmentAlreadyExist(PinotFSSegmentUploaderTest.java:77)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
...
```
cc: @Jackie-Jiang : should we just bump the timeout for this test? I guess it may happen if the VM this is running on is super slow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10910: Flaky Test PinotFSSegmentUploaderTest
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10910:
URL: https://github.com/apache/pinot/issues/10910#issuecomment-1595486217
Yeah, I can see the timeout is set pretty aggressive (100ms). We can definitely make it longer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mcvsubbu commented on issue #10910: Flaky Test PinotFSSegmentUploaderTest
Posted by "mcvsubbu (via GitHub)" <gi...@apache.org>.
mcvsubbu commented on issue #10910:
URL: https://github.com/apache/pinot/issues/10910#issuecomment-1595491068
I would prefer that we write unit tests to test the ```uploadSegment()``` method in ```PinotFSSegmentUploader``` class. Can we try to avoid sleeps in test? There is no right value for timeout since it can fail in some environment or another
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org