You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/03/30 08:43:36 UTC

Review Request: Remove offer before calling resourcesUnused()/resourcesRecovered() for it

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4570/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Summary
-------

Make sure removeOffer() is called before resourcesUnused()/resourcesRecovered() is called on the allocator.

This ensures that the allocator will see a correct value from master::Slave::resourcesFree().


This addresses bug MESOS-175.
    https://issues.apache.org/jira/browse/MESOS-175


Diffs
-----

  src/master/master.hpp 8a34d7e 
  src/master/master.cpp 4dc9ee0 
  src/tests/resource_offers_tests.cpp c1f1760 

Diff: https://reviews.apache.org/r/4570/diff


Testing
-------

make check (two new tests included)


Thanks,

Charles