You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/09/16 07:31:46 UTC

[GitHub] [ofbiz-plugins] CharlesNereide commented on a change in pull request #64: Best selling category template translation

CharlesNereide commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r709858522



##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
         <value xml:lang="zh">分配明细</value>
         <value xml:lang="zh-TW">分配細項</value>
     </property>
+    <property key="EcommerceBestSelling">

Review comment:
       At the beginning, that was my idea. But the template is called ShowBestSellingCategory.ftl, the screen is called showBestSellingCategory and the template is only for the category "Best Selling" (PCCT_BEST_SELL). So, for me, the label is dedicated to Best Selling category and it's better to spell the label according to its usage than to it spelling.
   Moreover, I wanted change english label "Popular categories" by "Best selling". I think that "Popular categories" would be more efficient for the "Most popular" category (PCCT_MOST_POPULAR) for exemple.
   But it's just my point of view ;).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org