You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/21 13:12:23 UTC

[GitHub] [spark] vicennial commented on pull request #39078: [SPARK-41534][CONNECT][SQL] Setup initial client module for Spark Connect

vicennial commented on PR #39078:
URL: https://github.com/apache/spark/pull/39078#issuecomment-1361296845

   @grundprinzip Looks like there are two options here if we want separate folders:
   
   - `connect/client/[scala/xyz]`
   - `connect/[scala/xyz]-client`
   
   WDYT about the latter option? That would keep clients isolated and it avoids the misnomer in `connect/client/scala` that makes it wrongfully imply that it's a language directory rather than a client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org