You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/07/12 01:44:25 UTC
Review Request 60788: Windows: Fixed long path support in
`reparsepoint.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60788/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
This patch fixes an error on my part where I accidentally didn't use the
`longpath` helper, but just `wide_stringify` in two instances.
Diffs
-----
3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 066c192586f0a9bf74127342e827f38c9de1b4ca
Diff: https://reviews.apache.org/r/60788/diff/1/
Testing
-------
mesos-tests
Fixes a bug I'd rather not talk about.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 60788: Windows: Fixed long path support in
`reparsepoint.hpp`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60788/#review180390
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60788]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 12, 2017, 9:44 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60788/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 9:44 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes an error on my part where I accidentally didn't use the
> `longpath` helper, but just `wide_stringify` in two instances.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 066c192586f0a9bf74127342e827f38c9de1b4ca
>
>
> Diff: https://reviews.apache.org/r/60788/diff/1/
>
>
> Testing
> -------
>
> mesos-tests
>
> Fixes a bug I'd rather not talk about.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 60788: Windows: Fixed long path support in
`reparsepoint.hpp`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60788/#review180277
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60788]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 12, 2017, 1:44 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60788/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 1:44 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes an error on my part where I accidentally didn't use the
> `longpath` helper, but just `wide_stringify` in two instances.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 066c192586f0a9bf74127342e827f38c9de1b4ca
>
>
> Diff: https://reviews.apache.org/r/60788/diff/1/
>
>
> Testing
> -------
>
> mesos-tests
>
> Fixes a bug I'd rather not talk about.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 60788: Windows: Fixed long path support in
`reparsepoint.hpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60788/#review180556
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 11, 2017, 6:44 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60788/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 6:44 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes an error on my part where I accidentally didn't use the
> `longpath` helper, but just `wide_stringify` in two instances.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 066c192586f0a9bf74127342e827f38c9de1b4ca
>
>
> Diff: https://reviews.apache.org/r/60788/diff/1/
>
>
> Testing
> -------
>
> mesos-tests
>
> Fixes a bug I'd rather not talk about.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>