[jira] Issue Comment Edited: (PDFBOX-422) Methods are marked as deprecated but they're effectively dead

["Gustavo Hexsel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672809#action_12672809 ] 

quartz edited comment on PDFBOX-422 at 2/11/09 2:27 PM:
----------------------------------------------------------------

Thanks for the prompt response.

Yes, I saw the methods, they just don't carry the text position anymore (also, blocks get merged).

This is fine, the class is doing what is supposed to (according to its name).  We had a use-case (specifically document redaction) that needed to bring back the text and the associated positions of each char, which we were doing by using the startup of the text block and each individual character width.

But that's a different matter.  Having the compiler warn me that the method does not @Override a parent method anymore is on the right track.

      was (Author: quartz):
    Thanks for the prompt response.

Yes, I saw the methods, they just don't carry the text position anymore (also, blocks get merged).

This is fine, the class is doing what is supposed to (according to its name).  We had a use-case (specifically document redaction) that needed to bring back the text and the associated positions of each char, which we were doing by using the startup of the text block and each individual character width.

  
> Methods are marked as deprecated but they're effectively dead
> -------------------------------------------------------------
>
>                 Key: PDFBOX-422
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-422
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Text extraction
>    Affects Versions: 0.8.0-incubator
>            Reporter: Gustavo Hexsel
>
> There are several methods on PDFTextStripper and PDFStreamEngine that are marked @deprecated, but they are not really used by the existing infrastructure anymore.
> This would be ok if such methods weren't callbacks.  In this case, it breaks pre-existing code, and prevents the compiler from letting you know the methods are not to be used anymore.
> Simply removing the methods would have been a much better solution in this case. 
> Example of said methods:
> org.apache.pdfbox.util.PDFTextStripper#processLineSeparator
> org.apache.pdfbox.util.PDFTextStripper#processWordSeparator
> org.apache.pdfbox.util.PDFTextStripper#writeCharacters

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.