You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/14 11:08:54 UTC
[GitHub] brooklyn-server pull request #431: SoftwareProcess integration tests: use IN...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/431
SoftwareProcess integration tests: use INSTALL_UNIQUE_LABEL
Fixes VanillaSoftwareProcessStreamsIntegrationTest.testGetsStreams,
for if run multiple times on the same machine.
@neykov can you take a quick look please?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/integration-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #431
----
commit ffb01ed4ecd51756a976e1200ab2f314050f3023
Author: Aled Sage <al...@gmail.com>
Date: 2016-11-14T11:02:13Z
SoftwareProcess integration tests: use INSTALL_UNIQUE_LABEL
Fixes VanillaSoftwareProcessStreamsIntegrationTest.testGetsStreams,
for if run multiple times on the same machine.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #431: SoftwareProcess integration tests: use IN...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/431#discussion_r87782693
--- Diff: software/base/src/test/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessIntegrationTest.java ---
@@ -51,7 +51,7 @@ public void setUp() throws Exception {
super.setUp();
localhost = app.getManagementContext().getLocationRegistry().getLocationManaged("localhost");
- runRecord = Files.createTempFile("testVanillaSoftwareProcess-runRecord", ".txt");
+ runRecord = Files.createTempFile("testVanillaSoftwareProcess-runRecord-"+Identifiers.makeRandomId(8), ".txt");
--- End diff --
`createTempFile` is supposed to ensure unique name, is this really needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #431: SoftwareProcess integration tests: use INSTALL_U...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/431
Good to merge, but don't really understand why randomize the temporary files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #431: SoftwareProcess integration tests: use IN...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #431: SoftwareProcess integration tests: use IN...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/431#discussion_r87901835
--- Diff: software/base/src/test/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessIntegrationTest.java ---
@@ -51,7 +51,7 @@ public void setUp() throws Exception {
super.setUp();
localhost = app.getManagementContext().getLocationRegistry().getLocationManaged("localhost");
- runRecord = Files.createTempFile("testVanillaSoftwareProcess-runRecord", ".txt");
+ runRecord = Files.createTempFile("testVanillaSoftwareProcess-runRecord-"+Identifiers.makeRandomId(8), ".txt");
--- End diff --
Not sure what guarantees `createTempFile` gives. If the previous temp files have been deleted, then might it reuse the name? Particularly if we run two tests within the same millisecond, which admittedly seems unlikely when they are integration tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---