You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/10 09:49:00 UTC
[jira] [Commented] (WEEX-350) [WXConvert CGFloat:] return nan may
cause anim crash
[ https://issues.apache.org/jira/browse/WEEX-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470156#comment-16470156 ]
ASF GitHub Bot commented on WEEX-350:
-------------------------------------
GitHub user chaoszm opened a pull request:
https://github.com/apache/incubator-weex/pull/1163
[WEEX-350][iOS] fix anim crash caused by problem that [WXConvert CGFl…
[WXConvert CGFloat:] when input value is unsupported,it will return nan value.in some case,anim operation will crash.therefore, build a new method to distinguish these two usages.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chaoszm/incubator-weex master-fix-convert-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1163
----
commit c7880b346b5af741d6c2113efdb22141d28c170b
Author: zouming.zm <zo...@...>
Date: 2018-05-10T09:40:15Z
[WEEX-350][iOS] fix anim crash caused by problem that [WXConvert CGFloat:] return nan when unsupported input
----
> [WXConvert CGFloat:] return nan may cause anim crash
> ----------------------------------------------------
>
> Key: WEEX-350
> URL: https://issues.apache.org/jira/browse/WEEX-350
> Project: Weex
> Issue Type: Bug
> Components: iOS
> Affects Versions: 0.18
> Reporter: zouming
> Assignee: xingZhang
> Priority: Major
>
> when outside input unsupported value, [WXConvert CGFloat:] return nan may cause anim crash.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)