[jira] [Commented] (WICKET-5672) Form#findSubmittingComponent() should not throw exceptions if the submitter is disabled/invisible

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093912#comment-14093912 ] 

ASF subversion and git services commented on WICKET-5672:
---------------------------------------------------------

Commit d20e568b51f9c8e4612472d143df4d49a3bd0e63 in wicket's branch refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=d20e568 ]

WICKET-5672 Form#findSubmittingComponent() should not throw exceptions if the submitter is disabled/invisible


> Form#findSubmittingComponent() should not throw exceptions if the submitter is disabled/invisible
> -------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5672
>                 URL: https://issues.apache.org/jira/browse/WICKET-5672
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.0.0-M2
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 7.0.0-M3
>
>
> As explained by a user at http://markmail.org/message/s262q4yc3ubymglr it is unexpected that org.apache.wicket.markup.html.form.Form#findSubmittingButton() throws runtime exceptions when the submitter is invisible or disabled.
> As discussed at http://markmail.org/message/qhjepkihr27uywaj the checks should be moved to the code related to executing the submitter's action method (i.e. onSubmit()) and leave all other users of Form#findSubmittingButton() decide for themselves whether the change of the visiblility/enable state is a problem of not.



--
This message was sent by Atlassian JIRA
(v6.2#6252)