[GitHub] ashb commented on a change in pull request #3: WIP: Add make

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #3: WIP: Add make
URL: https://github.com/apache/incubator-airflow-ci/pull/3#discussion_r220892562
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -95,7 +96,7 @@ RUN sed -i 's/^# en_US.UTF-8 UTF-8$/en_US.UTF-8 UTF-8/g' /etc/locale.gen \
 # Install Hadoop
 RUN cd /tmp && \
     wget -q https://archive.cloudera.com/cdh5/cdh/5/hadoop-${HADOOP_VERSION}-cdh5.11.0.tar.gz && \
-    tar xzf hadoop-${HADOOP_VERSION}-cdh5.11.0.tar.gz --strip-components 1 -C $HADOOP_HOME && \
+    tar xzf hadoop-${HADOOP_VERSION}-cdh5.11.0.tar.gz --absolute-names --strip-components 1 -C $HADOOP_HOME && \
 
 Review comment:
   Lets keep it, but just add a comment in to the docker file why we have it.
   
   (Cos of dockerfile semantics it should be like:
   
   ```
   # --absolute-names is cos of X
   RUN cd /tmp && \
   ...
   ```
   )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services