You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/29 07:54:36 UTC

[GitHub] [flink] Myracle opened a new pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Myracle opened a new pull request #19266:
URL: https://github.com/apache/flink/pull/19266


   ## What is the purpose of the change
   
   *In setence "- 配置 `jobmanager.scheduler: AdpaptiveBatch`", the word AdaptiveBatch is spelling wrong which may confuse the users.*
   
   
   ## Brief change log
   
     - *Modify spelling error in elastic_scaling.md*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wanglijie95 edited a comment on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
wanglijie95 edited a comment on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1082595991


   Thanks for your fix @Myracle, and thanks for review @MartijnVisser , can you help to pick this change to release 1.15? Because the release 1.15 also has this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged pull request #19266:
URL: https://github.com/apache/flink/pull/19266


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1081553543


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f531a8d81b4c8dfb494197442d323bbee4118604",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33882",
       "triggerID" : "f531a8d81b4c8dfb494197442d323bbee4118604",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f531a8d81b4c8dfb494197442d323bbee4118604 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33882) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1081553543


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f531a8d81b4c8dfb494197442d323bbee4118604",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33882",
       "triggerID" : "f531a8d81b4c8dfb494197442d323bbee4118604",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f531a8d81b4c8dfb494197442d323bbee4118604 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33882) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wanglijie95 commented on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1082595991


   Thanks for your fix @Myracle, and thanks for your review@MartijnVisser, can you help to pick this change to release 1.15? Because the release 1.15 also has this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1084043183


   Merged into release-1.15: 341deb239c7ea974af237f41e444cf42defc7bbd


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1084041082


   Thanks for reporting and fixing this spelling error! @Myracle 
   And thanks for reviewing the fix and merging it into master. @MartijnVisser 
   We absolute need this fix in release-1.15 to avoid misleading users. So I will pick it to release-1.15.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wanglijie95 edited a comment on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
wanglijie95 edited a comment on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1082595991


   Thanks for your fix @Myracle, and thanks for your review @MartijnVisser , can you help to pick this change to release 1.15? Because the release 1.15 also has this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1082704299


   @wanglijie95 I can definitely cherrypick this fix to `release-1.15` but I would like to know if @Myracle doesn't want to do that. I can help in merging it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19266: [hotfix][doc] Modify spelling error in elastic_scaling.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19266:
URL: https://github.com/apache/flink/pull/19266#issuecomment-1081553543


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f531a8d81b4c8dfb494197442d323bbee4118604",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f531a8d81b4c8dfb494197442d323bbee4118604",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f531a8d81b4c8dfb494197442d323bbee4118604 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org