You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/30 01:41:59 UTC
[jira] [Commented] (BEAM-1060) Make DoFnTester use new DoFn
[ https://issues.apache.org/jira/browse/BEAM-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707197#comment-15707197 ]
ASF GitHub Bot commented on BEAM-1060:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/incubator-beam/pull/1461
[BEAM-1060] Makes DoFnTester use new DoFn internally.
There were 2 remaining users of DoFnTester.of(OldDoFn):
- SplittableParDo.ProcessElements: this is fixed in
https://github.com/apache/incubator-beam/pull/1261
- GroupAlsoByWindowsProperties: this one is harder.
Various GABWDoFn's use OldDoFn.windowingInternals,
and we can't pass that through a new DoFn.
So instead I removed usage of DoFnTester from
GroupAlsoByWindowsProperties in favor of a tiny
hand-coded solution.
So after this PR and #1261 DoFnTester.of(OldDoFn) can be deleted.
R: @kennknowles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam tester-new-dofn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1461.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1461
----
commit 4cdccc044f6d7b7599860c3bc656a7b33905f79f
Author: Eugene Kirpichov <ki...@google.com>
Date: 2016-11-18T21:10:22Z
Makes DoFnTester use new DoFn internally.
There were 2 remaining users of DoFnTester.of(OldDoFn):
- SplittableParDo.ProcessElements: this is fixed in
https://github.com/apache/incubator-beam/pull/1261
- GroupAlsoByWindowsProperties: this one is harder.
Various GABWDoFn's use OldDoFn.windowingInternals,
and we can't pass that through a new DoFn.
So instead I removed usage of DoFnTester from
GroupAlsoByWindowsProperties in favor of a tiny
hand-coded solution.
So after #1261 DoFnTester.of(OldDoFn) can be deleted.
----
> Make DoFnTester use new DoFn
> ----------------------------
>
> Key: BEAM-1060
> URL: https://issues.apache.org/jira/browse/BEAM-1060
> Project: Beam
> Issue Type: Improvement
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)