[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27955 ]

ASF GitHub Bot logged work on TS-4809:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Sep/16 18:15
            Start Date: 02/Sep/16 18:15
    Worklog Time Spent: 10m 
      Work Description: GitHub user gtenev opened a pull request:

    https://github.com/apache/trafficserver/pull/960

    TS-4809 header_rewrite "hook" conditions checks

    Added a check to make sure "hook" conditions are first in the rule set
    and there is only one "hook" condition per rule set.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gtenev/trafficserver TS-4809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #960
    
----

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 27955)
            Time Spent: 10m
    Remaining Estimate: 0h

> [header_rewrite] check to make sure "hook" conditions are first in the rule set 
> --------------------------------------------------------------------------------
>
>                 Key: TS-4809
>                 URL: https://issues.apache.org/jira/browse/TS-4809
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Plugins
>            Reporter: Gancho Tenev
>            Assignee: Gancho Tenev
>             Fix For: 7.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1:8888 \
>     @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>    set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)