You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/06 04:01:26 UTC

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #41: [Issue #39]Add skip flag for cMessageId free

massakam commented on a change in pull request #41: [Issue #39]Add skip flag for cMessageId free
URL: https://github.com/apache/pulsar-client-node/pull/41#discussion_r310873304
 
 

 ##########
 File path: src/MessageId.h
 ##########
 @@ -41,6 +41,7 @@ class MessageId : public Napi::ObjectWrap<MessageId> {
  private:
   static Napi::FunctionReference constructor;
   pulsar_message_id_t *cMessageId;
+  bool skipcMessageIdFree = false;
 
 Review comment:
   I think skip**C**MessageIdFree is correct as a camel case variable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services