You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/01/13 18:34:36 UTC
[GitHub] flink pull request #3122: [FLINK-5485] [webfrontend] Mark compiled web front...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3122
[FLINK-5485] [webfrontend] Mark compiled web frontend files as binary when processed by git diff
Particularly beneficial now that javascript is minified, we can mark compiled web frontend files as binary when processed by git diff.
https://linux.die.net/man/5/gitattributes
This does not affect how files are displayed by github.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 5485_mark_compiled_web_frontend_files_as_binary_when_processed_by_git_diff
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3122
----
commit ace0272f9c3abc60645f2119744e88afa975a731
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-01-13T18:33:29Z
[FLINK-5485] [webfrontend] Mark compiled web frontend files as binary when processed by git diff
Particularly beneficial now that javascript is minified, we can mark
compiled web frontend files as binary when processed by git diff.
https://linux.die.net/man/5/gitattributes
This does not affect how files are displayed by github.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3122: [FLINK-5485] [webfrontend] Mark compiled web frontend fil...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3122
+1
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3122: [FLINK-5485] [webfrontend] Mark compiled web frontend fil...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3122
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3122: [FLINK-5485] [webfrontend] Mark compiled web front...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3122: [FLINK-5485] [webfrontend] Mark compiled web frontend fil...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3122
+1 makes sense. Would you mind merging this to release-1.2 and release-1.1 as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---