You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/16 08:50:59 UTC
[GitHub] [maven] slawekjaranowski opened a new pull request, #722: [MNG-5222] Improvement in deprecated params detection
slawekjaranowski opened a new pull request, #722:
URL: https://github.com/apache/maven/pull/722
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #722: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #722:
URL: https://github.com/apache/maven/pull/722#issuecomment-1105669878
Let me try to rephrase here:
* You are early validating (as compared to before) here *bofore* the actual mojo is polulated through DI?
* This interface can also be used to log if a mojo itself is deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #722: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #722:
URL: https://github.com/apache/maven/pull/722#issuecomment-1100660353
PR description updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski merged pull request #722: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #722:
URL: https://github.com/apache/maven/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #722: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #722:
URL: https://github.com/apache/maven/pull/722#issuecomment-1100623733
build on Jenkins fails due to using master branch from integration-test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #722: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #722:
URL: https://github.com/apache/maven/pull/722#issuecomment-1103517291
kindly ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #722: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #722:
URL: https://github.com/apache/maven/pull/722#issuecomment-1105686788
> Let me try to rephrase here:
>
> * You are early validating (as compared to before) here _bofore_ the actual mojo is polulated through DI?
yes, based on used configuration in XmlPlexusConfiguration
> * This interface can also be used to log if a mojo itself is deprecated?
checking for mojo itself is deprecated can be done in the same implementation - it is similar task, simply I wan't mix issues
but next implementation can be used for checking if read-only params is used in configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org