You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/10 23:01:12 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1844: MINOR: Remove version from parquet-fromcsv-help.txt
viirya opened a new pull request, #1844:
URL: https://github.com/apache/arrow-rs/pull/1844
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1844: MINOR: Remove version check from `test_command_help`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1844:
URL: https://github.com/apache/arrow-rs/pull/1844#issuecomment-1152856533
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1844?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1844](https://codecov.io/gh/apache/arrow-rs/pull/1844?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf562d3) into [master](https://codecov.io/gh/apache/arrow-rs/commit/c396dfb5035d22e57717b6dd365486b76eb611bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c396dfb) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1844 +/- ##
==========================================
- Coverage 83.48% 83.48% -0.01%
==========================================
Files 201 201
Lines 56838 56838
==========================================
- Hits 47452 47451 -1
- Misses 9386 9387 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/bin/parquet-fromcsv.rs](https://codecov.io/gh/apache/arrow-rs/pull/1844/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYmluL3BhcnF1ZXQtZnJvbWNzdi5ycw==) | `0.00% <ø> (ø)` | |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1844/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (-0.23%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1844?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1844?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c396dfb...bf562d3](https://codecov.io/gh/apache/arrow-rs/pull/1844?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #1844: MINOR: Remove version check from `test_command_help`
Posted by GitBox <gi...@apache.org>.
viirya merged PR #1844:
URL: https://github.com/apache/arrow-rs/pull/1844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1844: MINOR: Remove version check from `test_command_help`
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1844:
URL: https://github.com/apache/arrow-rs/pull/1844#discussion_r894975699
##########
parquet/src/bin/parquet-fromcsv.rs:
##########
@@ -403,7 +403,9 @@ mod tests {
let mut buffer_vec = Vec::new();
let mut buffer = std::io::Cursor::new(&mut buffer_vec);
cmd.write_long_help(&mut buffer).unwrap();
- let actual = String::from_utf8(buffer_vec).unwrap();
+ let mut actual = String::from_utf8(buffer_vec).unwrap();
Review Comment:
```suggestion
// Remove Parquet version string from the help text
let mut actual = String::from_utf8(buffer_vec).unwrap();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1844: MINOR: Remove version check from `test_command_help`
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1844:
URL: https://github.com/apache/arrow-rs/pull/1844#discussion_r894973355
##########
parquet/src/bin/parquet-fromcsv.rs:
##########
@@ -403,7 +403,9 @@ mod tests {
let mut buffer_vec = Vec::new();
let mut buffer = std::io::Cursor::new(&mut buffer_vec);
cmd.write_long_help(&mut buffer).unwrap();
- let actual = String::from_utf8(buffer_vec).unwrap();
+ let mut actual = String::from_utf8(buffer_vec).unwrap();
Review Comment:
Maybe a comment explaining what this is doing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1844: MINOR: Remove version check from `test_command_help`
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1844:
URL: https://github.com/apache/arrow-rs/pull/1844#issuecomment-1152809387
cc @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1844: MINOR: Remove version check from `test_command_help`
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1844:
URL: https://github.com/apache/arrow-rs/pull/1844#issuecomment-1152861027
Thanks @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org