[jira] [Comment Edited] (HBASE-14886) ReplicationAdmin does not use full peer configuration

["Heng Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028101#comment-15028101 ] 

Heng Chen edited comment on HBASE-14886 at 11/26/15 3:41 AM:
-------------------------------------------------------------

ReplicationPeerZKImpl is not used to create peer,   peer was created in ReplicationPeersZKImpl.
I am not sure it is a bug. 
Thanks [~ghelmling]. :)


was (Author: chenheng):
ReplicationPeerZKImpl is not used to create peer,   peer was created in ReplicationPeersZKImpl.
And the configuration in ReplicationPeerZKImpl is useless currently.  So it is not a bug.  
The code here is some confused. And it has some changes in HBASE-11393

Thanks [~ghelmling]. :)

> ReplicationAdmin does not use full peer configuration
> -----------------------------------------------------
>
>                 Key: HBASE-14886
>                 URL: https://issues.apache.org/jira/browse/HBASE-14886
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: hbase-14886-v1.patch, hbase-14886.patch
>
>
> In {{listValidReplicationPeers()}}, we're creating the peer {{Configuration}} based on the source connection configuration and simply applying the peer ZK cluster key.  This causes any additional properties present in the {{ReplicationPeerConfig}} configuration to not be applied.
> We should instead be using the configuration returned by {{ReplicationPeers.getPeerConf()}}, which we already call in that method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)