[GitHub] [apisix-java-plugin-runner] juzhiyuan commented on a change in pull request #38: docs: refactored directory and added config.json

[GitBox <gi...@apache.org>]

juzhiyuan commented on a change in pull request #38:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/38#discussion_r656615259



##########
File path: docs/en/latest/the-internal-of-apisix-java-plugin-runner.md
##########
@@ -43,16 +66,16 @@ You can refer to the [ext-plugin.fbs](https://github.com/api7/ext-plugin-proto/b
 apisix-java-plugin-runner and APISIX use a private binary protocol for coding and decoding.
 The protocol format is
 
-```
+```shell
 1 byte of type + 3 bytes of length + data
 ```
 
 The type can be 0 ~ 7, and the length can be [0, 8M). The length of data is determined by length.
 
 The current type takes the following values
 
-* 0 means error
-* 1 means prepare_conf
-* 2 means http_req_call
+- 0 means error

Review comment:
       Your IDE format this?

##########
File path: docs/en/latest/the-internal-of-apisix-java-plugin-runner.md
##########
@@ -43,16 +66,16 @@ You can refer to the [ext-plugin.fbs](https://github.com/api7/ext-plugin-proto/b
 apisix-java-plugin-runner and APISIX use a private binary protocol for coding and decoding.
 The protocol format is
 
-```
+```shell

Review comment:
       No, this is just a Text IMO

##########
File path: docs/en/latest/the-internal-of-apisix-java-plugin-runner.md
##########
@@ -43,16 +66,16 @@ You can refer to the [ext-plugin.fbs](https://github.com/api7/ext-plugin-proto/b
 apisix-java-plugin-runner and APISIX use a private binary protocol for coding and decoding.
 The protocol format is
 
-```
+```shell
 1 byte of type + 3 bytes of length + data
 ```
 
 The type can be 0 ~ 7, and the length can be [0, 8M). The length of data is determined by length.
 
 The current type takes the following values
 
-* 0 means error
-* 1 means prepare_conf
-* 2 means http_req_call
+- 0 means error
+- 1 means prepare_conf
+- 2 means http_req_call

Review comment:
       Please use `*` as other files :)

##########
File path: docs/en/latest/how-it-works.md
##########
@@ -37,7 +60,7 @@ and APISIX communicate between processes and must be consistent.
 
 Note: If you see some error logs like
 
-```
+```shell

Review comment:
       not sure if it's a shell




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org