You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/06 02:37:46 UTC

[GitHub] [spark] kiszk commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines

kiszk commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-595568767
 
 
   Umm, I believe that this value depends on the environment (CPU, lib. version, JIT compiler version, ...). According to the past experiments, in general, the constants will be replaced with the property later.   
   
   How about following [this approach](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala#L696
   ) in mllib?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org