You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "dd-david-levin (via GitHub)" <gi...@apache.org> on 2026/03/09 14:57:48 UTC

[PR] feat(substrait): implement consume_nested for List expressions [datafusion]

dd-david-levin opened a new pull request, #20821:
URL: https://github.com/apache/datafusion/pull/20821

   ## Summary
   
   - Implements `consume_nested` in the default `SubstraitConsumer` trait to handle `Nested::List` expressions, which represent inline array constructors like `ARRAY['a', 'b']` in Substrait plans
   - `Nested::List` is converted to a `make_array(...)` scalar function call by recursively converting each element via `from_substrait_rex`
   - `Nested::Struct` and `Nested::Map` return `not_impl_err` for now (separate follow-ups)
   
   ## Motivation
   
   Previously, any Substrait plan containing an inline array constructor (e.g. from SQL like `SELECT f(col, ARRAY['x', 'y'])`) would fail at the consumer with:
   
   ```
   This feature is not implemented: Nested expression not supported
   ```
   
   The fix follows the same pattern used by every other expression type in the consumer — a `from_nested` function in a dedicated `expr/nested.rs` module, called from the trait's default `consume_nested` method.
   
   ## Test plan
   
   - [ ] Existing substrait tests pass
   - [ ] Manual verification: `SELECT make_array('a', 'b')` roundtrips through Substrait producer → consumer correctly
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "alexanderbianchi (via GitHub)" <gi...@apache.org>.
alexanderbianchi commented on PR #20821:
URL: https://github.com/apache/datafusion/pull/20821#issuecomment-4063521305

   https://github.com/apache/datafusion/pull/20953
   FYI , I think we can redirect to the above PR which includes tests and a couple small code cleanliness improvements. It still doesn't implement map + struct nested types (in purpose, since those are non-trivial compared to the Array).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "alexanderbianchi (via GitHub)" <gi...@apache.org>.
alexanderbianchi commented on code in PR #20821:
URL: https://github.com/apache/datafusion/pull/20821#discussion_r2936982420


##########
datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::logical_plan::consumer::SubstraitConsumer;
+use crate::logical_plan::consumer::expr::from_substrait_rex;
+use datafusion::common::{DFSchema, not_impl_err, substrait_err};
+use datafusion::execution::FunctionRegistry;
+use datafusion::logical_expr::Expr;
+use substrait::proto::expression::Nested;
+use substrait::proto::expression::nested::NestedType;
+
+/// Convert a Substrait Nested expression (List, Struct, Map constructors) to a DataFusion Expr.
+///
+/// Nested::List is converted to a `make_array(...)` scalar function call.
+pub async fn from_nested(
+    consumer: &impl SubstraitConsumer,
+    nested: &Nested,
+    input_schema: &DFSchema,
+) -> datafusion::common::Result<Expr> {
+    let Some(nested_type) = nested.nested_type.as_ref() else {
+        return substrait_err!("Nested expression must set nested_type");
+    };
+
+    match nested_type {
+        NestedType::List(list) => {
+            let mut args = Vec::with_capacity(list.values.len());
+            for expr in &list.values {
+                args.push(from_substrait_rex(consumer, expr, input_schema).await?);
+            }
+
+            let make_array_udf = consumer.get_function_registry().udf("make_array")?;
+            Ok(Expr::ScalarFunction(
+                datafusion::logical_expr::expr::ScalarFunction::new_udf(
+                    make_array_udf.to_owned(),

Review Comment:
   This will fail for empty arrays, as `make_array` fails on empty arrays. We might consider just making `make_array` accept no args. My pr here https://github.com/apache/datafusion/pull/20953 supports that case. 
   
   Thinking the best path would be to always use make array like this and update it to support 0 args, can see how feasible that is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "alexanderbianchi (via GitHub)" <gi...@apache.org>.
alexanderbianchi commented on code in PR #20821:
URL: https://github.com/apache/datafusion/pull/20821#discussion_r2936982420


##########
datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::logical_plan::consumer::SubstraitConsumer;
+use crate::logical_plan::consumer::expr::from_substrait_rex;
+use datafusion::common::{DFSchema, not_impl_err, substrait_err};
+use datafusion::execution::FunctionRegistry;
+use datafusion::logical_expr::Expr;
+use substrait::proto::expression::Nested;
+use substrait::proto::expression::nested::NestedType;
+
+/// Convert a Substrait Nested expression (List, Struct, Map constructors) to a DataFusion Expr.
+///
+/// Nested::List is converted to a `make_array(...)` scalar function call.
+pub async fn from_nested(
+    consumer: &impl SubstraitConsumer,
+    nested: &Nested,
+    input_schema: &DFSchema,
+) -> datafusion::common::Result<Expr> {
+    let Some(nested_type) = nested.nested_type.as_ref() else {
+        return substrait_err!("Nested expression must set nested_type");
+    };
+
+    match nested_type {
+        NestedType::List(list) => {
+            let mut args = Vec::with_capacity(list.values.len());
+            for expr in &list.values {
+                args.push(from_substrait_rex(consumer, expr, input_schema).await?);
+            }
+
+            let make_array_udf = consumer.get_function_registry().udf("make_array")?;
+            Ok(Expr::ScalarFunction(
+                datafusion::logical_expr::expr::ScalarFunction::new_udf(
+                    make_array_udf.to_owned(),

Review Comment:
   This will fail for empty arrays, as `make_array` fails on empty arrays. We might consider just making `make_array` accept no args. My pr here https://github.com/apache/datafusion/pull/20953 supports that case. 
   
   Thinking the best path would be to always use make array like this and update it to support 0 args, can see how feasible that is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "dd-david-levin (via GitHub)" <gi...@apache.org>.
dd-david-levin closed pull request #20821: feat(substrait): implement consume_nested for List expressions
URL: https://github.com/apache/datafusion/pull/20821


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "alexanderbianchi (via GitHub)" <gi...@apache.org>.
alexanderbianchi commented on code in PR #20821:
URL: https://github.com/apache/datafusion/pull/20821#discussion_r2936973411


##########
datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::logical_plan::consumer::SubstraitConsumer;
+use crate::logical_plan::consumer::expr::from_substrait_rex;
+use datafusion::common::{DFSchema, not_impl_err, substrait_err};
+use datafusion::execution::FunctionRegistry;
+use datafusion::logical_expr::Expr;
+use substrait::proto::expression::Nested;
+use substrait::proto::expression::nested::NestedType;
+
+/// Convert a Substrait Nested expression (List, Struct, Map constructors) to a DataFusion Expr.
+///
+/// Nested::List is converted to a `make_array(...)` scalar function call.
+pub async fn from_nested(
+    consumer: &impl SubstraitConsumer,
+    nested: &Nested,
+    input_schema: &DFSchema,
+) -> datafusion::common::Result<Expr> {
+    let Some(nested_type) = nested.nested_type.as_ref() else {
+        return substrait_err!("Nested expression must set nested_type");
+    };
+
+    match nested_type {
+        NestedType::List(list) => {
+            let mut args = Vec::with_capacity(list.values.len());
+            for expr in &list.values {
+                args.push(from_substrait_rex(consumer, expr, input_schema).await?);
+            }
+
+            let make_array_udf = consumer.get_function_registry().udf("make_array")?;
+            Ok(Expr::ScalarFunction(
+                datafusion::logical_expr::expr::ScalarFunction::new_udf(
+                    make_array_udf.to_owned(),
+                    args,
+                ),
+            ))
+        }
+        NestedType::Struct(_) => {
+            not_impl_err!("Nested Struct expression is not yet supported")
+        }
+        NestedType::Map(_) => {
+            not_impl_err!("Nested Map expression is not yet supported")
+        }

Review Comment:
   I'd say this PR is well scoped enough that those can be follow up, given the current support for NestedType is 0 anyways we aren't breaking anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "LiaCastaneda (via GitHub)" <gi...@apache.org>.
LiaCastaneda commented on code in PR #20821:
URL: https://github.com/apache/datafusion/pull/20821#discussion_r2921282476


##########
datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::logical_plan::consumer::SubstraitConsumer;
+use crate::logical_plan::consumer::expr::from_substrait_rex;
+use datafusion::common::{DFSchema, not_impl_err, substrait_err};
+use datafusion::execution::FunctionRegistry;
+use datafusion::logical_expr::Expr;
+use substrait::proto::expression::Nested;
+use substrait::proto::expression::nested::NestedType;
+
+/// Convert a Substrait Nested expression (List, Struct, Map constructors) to a DataFusion Expr.
+///
+/// Nested::List is converted to a `make_array(...)` scalar function call.
+pub async fn from_nested(
+    consumer: &impl SubstraitConsumer,
+    nested: &Nested,
+    input_schema: &DFSchema,
+) -> datafusion::common::Result<Expr> {
+    let Some(nested_type) = nested.nested_type.as_ref() else {
+        return substrait_err!("Nested expression must set nested_type");
+    };
+
+    match nested_type {
+        NestedType::List(list) => {
+            let mut args = Vec::with_capacity(list.values.len());
+            for expr in &list.values {
+                args.push(from_substrait_rex(consumer, expr, input_schema).await?);
+            }
+
+            let make_array_udf = consumer.get_function_registry().udf("make_array")?;
+            Ok(Expr::ScalarFunction(
+                datafusion::logical_expr::expr::ScalarFunction::new_udf(
+                    make_array_udf.to_owned(),
+                    args,
+                ),
+            ))
+        }
+        NestedType::Struct(_) => {
+            not_impl_err!("Nested Struct expression is not yet supported")
+        }
+        NestedType::Map(_) => {
+            not_impl_err!("Nested Map expression is not yet supported")
+        }

Review Comment:
   Should we support these types as well? 



##########
datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:
##########


Review Comment:
   I see the substrait producer does not currently have support for `Nested` types as well -- it will never produce a substrait plan with a `Nested` type in it. This means means roundtrips with DataFusion's substrait producer <-> consumer are not possible, but it is possible to have `NestedType` from an external substrait producer, so I think this is a valid solution still.



##########
datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:
##########
@@ -342,10 +342,10 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
 
     async fn consume_nested(
         &self,
-        _expr: &Nested,
-        _input_schema: &DFSchema,
+        expr: &Nested,
+        input_schema: &DFSchema,
     ) -> datafusion::common::Result<Expr> {
-        not_impl_err!("Nested expression not supported")
+        from_nested(self, expr, input_schema).await
     }

Review Comment:
   Do you think we should add a test in `datafusion/substrait/tests/cases/logical_plans.rs`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "alexanderbianchi (via GitHub)" <gi...@apache.org>.
alexanderbianchi commented on code in PR #20821:
URL: https://github.com/apache/datafusion/pull/20821#discussion_r2936982420


##########
datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::logical_plan::consumer::SubstraitConsumer;
+use crate::logical_plan::consumer::expr::from_substrait_rex;
+use datafusion::common::{DFSchema, not_impl_err, substrait_err};
+use datafusion::execution::FunctionRegistry;
+use datafusion::logical_expr::Expr;
+use substrait::proto::expression::Nested;
+use substrait::proto::expression::nested::NestedType;
+
+/// Convert a Substrait Nested expression (List, Struct, Map constructors) to a DataFusion Expr.
+///
+/// Nested::List is converted to a `make_array(...)` scalar function call.
+pub async fn from_nested(
+    consumer: &impl SubstraitConsumer,
+    nested: &Nested,
+    input_schema: &DFSchema,
+) -> datafusion::common::Result<Expr> {
+    let Some(nested_type) = nested.nested_type.as_ref() else {
+        return substrait_err!("Nested expression must set nested_type");
+    };
+
+    match nested_type {
+        NestedType::List(list) => {
+            let mut args = Vec::with_capacity(list.values.len());
+            for expr in &list.values {
+                args.push(from_substrait_rex(consumer, expr, input_schema).await?);
+            }
+
+            let make_array_udf = consumer.get_function_registry().udf("make_array")?;
+            Ok(Expr::ScalarFunction(
+                datafusion::logical_expr::expr::ScalarFunction::new_udf(
+                    make_array_udf.to_owned(),

Review Comment:
   This will fail for empty arrays, as `make_array` fails on empty arrays.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat(substrait): implement consume_nested for List expressions [datafusion]

Posted by "alexanderbianchi (via GitHub)" <gi...@apache.org>.
alexanderbianchi commented on code in PR #20821:
URL: https://github.com/apache/datafusion/pull/20821#discussion_r2936981551


##########
datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::logical_plan::consumer::SubstraitConsumer;
+use crate::logical_plan::consumer::expr::from_substrait_rex;
+use datafusion::common::{DFSchema, not_impl_err, substrait_err};
+use datafusion::execution::FunctionRegistry;
+use datafusion::logical_expr::Expr;
+use substrait::proto::expression::Nested;
+use substrait::proto::expression::nested::NestedType;
+
+/// Convert a Substrait Nested expression (List, Struct, Map constructors) to a DataFusion Expr.
+///
+/// Nested::List is converted to a `make_array(...)` scalar function call.
+pub async fn from_nested(
+    consumer: &impl SubstraitConsumer,
+    nested: &Nested,
+    input_schema: &DFSchema,
+) -> datafusion::common::Result<Expr> {
+    let Some(nested_type) = nested.nested_type.as_ref() else {
+        return substrait_err!("Nested expression must set nested_type");
+    };
+
+    match nested_type {
+        NestedType::List(list) => {
+            let mut args = Vec::with_capacity(list.values.len());
+            for expr in &list.values {
+                args.push(from_substrait_rex(consumer, expr, input_schema).await?);

Review Comment:
   This could be just consumed with the consumer instead of directly calling `from_substrait_rex`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org