You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Jarek Potiuk (JIRA)" <ji...@apache.org> on 2019/07/29 14:48:00 UTC

[jira] [Closed] (AIRFLOW-5004) Stable/test image should be selectable via TRAVIS_BRANCH environment variable

     [ https://issues.apache.org/jira/browse/AIRFLOW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Potiuk closed AIRFLOW-5004.
---------------------------------
       Resolution: Won't Fix
    Fix Version/s:     (was: 1.10.4)

We will only use v1-10-test image for both test and stable branch in v1-10. No need for two separate images.

> Stable/test image should be selectable via TRAVIS_BRANCH environment variable
> -----------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5004
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5004
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 1.10.4, 2.0.0
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>
> When building CI images you need to know whether you use v1-10-test or v1-10-stable branch (and use corresponding image).
> Currently the default branch is read from _default_branch.sh . This is not a problem for master/v1-10-test distinction because those are in different "physical" branches, but v1-10-stable and v1-10-test are actually following one-another (v1-10-test moves first and when several commits pass, then stable branch follows).
> Therefore we need to utilise TRAVIS_BRANCH variable - this variable works in two modes - for PRs it is the branch that the PR is going to be merged to, whereas for triggered builds it's the branch from which the build was triggered. This is perfect for us to determine which image should be used during build.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)