You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/27 16:07:11 UTC

[Impala-ASF-CR] IMPALA-11399: Download shell dependencies from PyPI

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18668

to look at the new patch set (#6).

Change subject: IMPALA-11399: Download shell dependencies from PyPI
......................................................................

IMPALA-11399: Download shell dependencies from PyPI

Downloads shell dependencies from PyPI rather than including them in the
repository. Simplifies dependency updates so we only need to update
requirements.txt.

Removes old dependencies from requirements.txt. configparser is included
in all versions of Python we support, and setuptools is generally
installed as a system package. PyPI configparser does include Python 3
extensions over Python 2's ConfigParser, but since we didn't include
configparser in the tarball I conclude we don't use those extensions.

Change-Id: I3b76e112ba9d0db19fae3e8eb15fd54a721f80fd
---
M bin/impala-config.sh
M infra/python/deps/download_requirements
M infra/python/deps/find_py26.py
M infra/python/deps/pip_download.py
M shell/.gitignore
D shell/ext-py/bitarray-2.3.0/CHANGE_LOG
D shell/ext-py/bitarray-2.3.0/LICENSE
D shell/ext-py/bitarray-2.3.0/README.rst
D shell/ext-py/bitarray-2.3.0/bitarray/__init__.py
D shell/ext-py/bitarray-2.3.0/bitarray/__init__.pyi
D shell/ext-py/bitarray-2.3.0/bitarray/_bitarray.c
D shell/ext-py/bitarray-2.3.0/bitarray/_util.c
D shell/ext-py/bitarray-2.3.0/bitarray/architecture.txt
D shell/ext-py/bitarray-2.3.0/bitarray/bitarray.h
D shell/ext-py/bitarray-2.3.0/bitarray/copy_n.txt
D shell/ext-py/bitarray-2.3.0/bitarray/py.typed
D shell/ext-py/bitarray-2.3.0/bitarray/pythoncapi_compat.h
D shell/ext-py/bitarray-2.3.0/bitarray/test_bitarray.py
D shell/ext-py/bitarray-2.3.0/bitarray/test_data.pickle
D shell/ext-py/bitarray-2.3.0/bitarray/test_util.py
D shell/ext-py/bitarray-2.3.0/bitarray/util.py
D shell/ext-py/bitarray-2.3.0/bitarray/util.pyi
D shell/ext-py/bitarray-2.3.0/contributing.md
D shell/ext-py/bitarray-2.3.0/setup.py
D shell/ext-py/bitarray-2.3.0/update_doc.py
D shell/ext-py/kerberos-1.3.1/MANIFEST.in
D shell/ext-py/kerberos-1.3.1/PKG-INFO
D shell/ext-py/kerberos-1.3.1/README.md
D shell/ext-py/kerberos-1.3.1/pysrc/kerberos.py
D shell/ext-py/kerberos-1.3.1/setup.cfg
D shell/ext-py/kerberos-1.3.1/setup.py
D shell/ext-py/kerberos-1.3.1/src/base64.c
D shell/ext-py/kerberos-1.3.1/src/base64.h
D shell/ext-py/kerberos-1.3.1/src/kerberos.c
D shell/ext-py/kerberos-1.3.1/src/kerberosbasic.c
D shell/ext-py/kerberos-1.3.1/src/kerberosbasic.h
D shell/ext-py/kerberos-1.3.1/src/kerberosgss.c
D shell/ext-py/kerberos-1.3.1/src/kerberosgss.h
D shell/ext-py/kerberos-1.3.1/src/kerberospw.c
D shell/ext-py/kerberos-1.3.1/src/kerberospw.h
D shell/ext-py/prettytable-0.7.2/CHANGELOG
D shell/ext-py/prettytable-0.7.2/COPYING
D shell/ext-py/prettytable-0.7.2/MANIFEST.in
D shell/ext-py/prettytable-0.7.2/PKG-INFO
D shell/ext-py/prettytable-0.7.2/README
D shell/ext-py/prettytable-0.7.2/prettytable.py
D shell/ext-py/prettytable-0.7.2/setup.cfg
D shell/ext-py/prettytable-0.7.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
D shell/ext-py/six-1.14.0/CHANGES
D shell/ext-py/six-1.14.0/CONTRIBUTORS
D shell/ext-py/six-1.14.0/LICENSE
D shell/ext-py/six-1.14.0/MANIFEST.in
D shell/ext-py/six-1.14.0/README.rst
D shell/ext-py/six-1.14.0/setup.cfg
D shell/ext-py/six-1.14.0/setup.py
D shell/ext-py/six-1.14.0/six.py
D shell/ext-py/six-1.14.0/test_six.py
D shell/ext-py/six-1.14.0/tox.ini
D shell/ext-py/sqlparse-0.3.1/AUTHORS
D shell/ext-py/sqlparse-0.3.1/CHANGELOG
D shell/ext-py/sqlparse-0.3.1/LICENSE
D shell/ext-py/sqlparse-0.3.1/MANIFEST.in
D shell/ext-py/sqlparse-0.3.1/README.rst
D shell/ext-py/sqlparse-0.3.1/TODO
D shell/ext-py/sqlparse-0.3.1/setup.cfg
D shell/ext-py/sqlparse-0.3.1/setup.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/__init__.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/__main__.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/cli.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/compat.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/engine/__init__.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/engine/filter_stack.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/engine/grouping.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/engine/statement_splitter.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/exceptions.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/filters/__init__.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/filters/aligned_indent.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/filters/others.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/filters/output.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/filters/reindent.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/filters/right_margin.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/filters/tokens.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/formatter.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/keywords.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/lexer.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/sql.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/tokens.py
D shell/ext-py/sqlparse-0.3.1/sqlparse/utils.py
D shell/ext-py/sqlparse-0.3.1/tests/__init__.py
D shell/ext-py/sqlparse-0.3.1/tests/conftest.py
D shell/ext-py/sqlparse-0.3.1/tests/files/_Make_DirEntry.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/begintag.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/begintag_2.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/dashcomment.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/encoding_gbk.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/encoding_utf8.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/function.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/function_psql.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/function_psql2.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/function_psql3.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/function_psql4.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/huge_select.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/stream.sql
D shell/ext-py/sqlparse-0.3.1/tests/files/test_cp1251.sql
D shell/ext-py/sqlparse-0.3.1/tests/test_cli.py
D shell/ext-py/sqlparse-0.3.1/tests/test_format.py
D shell/ext-py/sqlparse-0.3.1/tests/test_grouping.py
D shell/ext-py/sqlparse-0.3.1/tests/test_keywords.py
D shell/ext-py/sqlparse-0.3.1/tests/test_parse.py
D shell/ext-py/sqlparse-0.3.1/tests/test_regressions.py
D shell/ext-py/sqlparse-0.3.1/tests/test_split.py
D shell/ext-py/sqlparse-0.3.1/tests/test_tokenize.py
D shell/ext-py/sqlparse-0.3.1/tox.ini
D shell/ext-py/thrift-0.14.2/CMakeLists.txt
D shell/ext-py/thrift-0.14.2/MANIFEST.in
D shell/ext-py/thrift-0.14.2/Makefile.am
D shell/ext-py/thrift-0.14.2/README.md
D shell/ext-py/thrift-0.14.2/coding_standards.md
D shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
D shell/ext-py/thrift-0.14.2/setup.cfg
D shell/ext-py/thrift-0.14.2/setup.py
D shell/ext-py/thrift-0.14.2/src/TMultiplexedProcessor.py
D shell/ext-py/thrift-0.14.2/src/TRecursive.py
D shell/ext-py/thrift-0.14.2/src/TSCons.py
D shell/ext-py/thrift-0.14.2/src/TSerialization.py
D shell/ext-py/thrift-0.14.2/src/TTornado.py
D shell/ext-py/thrift-0.14.2/src/Thrift.py
D shell/ext-py/thrift-0.14.2/src/__init__.py
D shell/ext-py/thrift-0.14.2/src/compat.py
D shell/ext-py/thrift-0.14.2/src/ext/binary.cpp
D shell/ext-py/thrift-0.14.2/src/ext/binary.h
D shell/ext-py/thrift-0.14.2/src/ext/compact.cpp
D shell/ext-py/thrift-0.14.2/src/ext/compact.h
D shell/ext-py/thrift-0.14.2/src/ext/endian.h
D shell/ext-py/thrift-0.14.2/src/ext/module.cpp
D shell/ext-py/thrift-0.14.2/src/ext/protocol.h
D shell/ext-py/thrift-0.14.2/src/ext/protocol.tcc
D shell/ext-py/thrift-0.14.2/src/ext/types.cpp
D shell/ext-py/thrift-0.14.2/src/ext/types.h
D shell/ext-py/thrift-0.14.2/src/protocol/TBase.py
D shell/ext-py/thrift-0.14.2/src/protocol/TBinaryProtocol.py
D shell/ext-py/thrift-0.14.2/src/protocol/TCompactProtocol.py
D shell/ext-py/thrift-0.14.2/src/protocol/THeaderProtocol.py
D shell/ext-py/thrift-0.14.2/src/protocol/TJSONProtocol.py
D shell/ext-py/thrift-0.14.2/src/protocol/TMultiplexedProtocol.py
D shell/ext-py/thrift-0.14.2/src/protocol/TProtocol.py
D shell/ext-py/thrift-0.14.2/src/protocol/TProtocolDecorator.py
D shell/ext-py/thrift-0.14.2/src/protocol/__init__.py
D shell/ext-py/thrift-0.14.2/src/server/THttpServer.py
D shell/ext-py/thrift-0.14.2/src/server/TNonblockingServer.py
D shell/ext-py/thrift-0.14.2/src/server/TProcessPoolServer.py
D shell/ext-py/thrift-0.14.2/src/server/TServer.py
D shell/ext-py/thrift-0.14.2/src/server/__init__.py
D shell/ext-py/thrift-0.14.2/src/transport/THeaderTransport.py
D shell/ext-py/thrift-0.14.2/src/transport/THttpClient.py
D shell/ext-py/thrift-0.14.2/src/transport/TSSLSocket.py
D shell/ext-py/thrift-0.14.2/src/transport/TSocket.py
D shell/ext-py/thrift-0.14.2/src/transport/TTransport.py
D shell/ext-py/thrift-0.14.2/src/transport/TTwisted.py
D shell/ext-py/thrift-0.14.2/src/transport/TZlibTransport.py
D shell/ext-py/thrift-0.14.2/src/transport/__init__.py
D shell/ext-py/thrift-0.14.2/src/transport/sslcompat.py
D shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
D shell/ext-py/thrift-0.14.2/test/test_socket.py
D shell/ext-py/thrift-0.14.2/test/test_sslsocket.py
D shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
D shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
D shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
D shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
D shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
D shell/ext-py/thrift-0.14.2/test/thrift_json.py
D shell/ext-py/thrift-0.14.2/test/thrift_transport.py
D shell/ext-py/thrift_sasl-0.4.3/CHANGELOG.md
D shell/ext-py/thrift_sasl-0.4.3/LICENSE
D shell/ext-py/thrift_sasl-0.4.3/README.md
D shell/ext-py/thrift_sasl-0.4.3/setup.py
D shell/ext-py/thrift_sasl-0.4.3/thrift_sasl/__init__.py
M shell/make_shell_tarball.sh
A shell/packaging/download_requirements
M shell/packaging/requirements.txt
188 files changed, 58 insertions(+), 45,527 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18668/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b76e112ba9d0db19fae3e8eb15fd54a721f80fd
Gerrit-Change-Number: 18668
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>