You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/01/22 08:07:46 UTC
svn commit: r1436768 [12/13] - in /commons/proper/lang/trunk/src:
main/java/org/apache/commons/lang3/
main/java/org/apache/commons/lang3/builder/
main/java/org/apache/commons/lang3/concurrent/
main/java/org/apache/commons/lang3/event/ main/java/org/apa...
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java Tue Jan 22 07:07:42 2013
@@ -133,7 +133,7 @@ public class FastDatePrinter implements
* @param locale non-null locale to use
* @throws NullPointerException if pattern, timeZone, or locale is null.
*/
- protected FastDatePrinter(String pattern, TimeZone timeZone, Locale locale) {
+ protected FastDatePrinter(final String pattern, final TimeZone timeZone, final Locale locale) {
mPattern = pattern;
mTimeZone = timeZone;
mLocale = locale;
@@ -294,7 +294,7 @@ public class FastDatePrinter implements
* @param indexRef index references
* @return parsed token
*/
- protected String parseToken(String pattern, int[] indexRef) {
+ protected String parseToken(final String pattern, final int[] indexRef) {
StringBuilder buf = new StringBuilder();
int i = indexRef[0];
@@ -353,7 +353,7 @@ public class FastDatePrinter implements
* @param padding the padding required
* @return a new rule with the correct padding
*/
- protected NumberRule selectNumberRule(int field, int padding) {
+ protected NumberRule selectNumberRule(final int field, final int padding) {
switch (padding) {
case 1:
return new UnpaddedNumberField(field);
@@ -376,7 +376,7 @@ public class FastDatePrinter implements
* @return the buffer passed in
*/
@Override
- public StringBuffer format(Object obj, StringBuffer toAppendTo, FieldPosition pos) {
+ public StringBuffer format(final Object obj, final StringBuffer toAppendTo, final FieldPosition pos) {
if (obj instanceof Date) {
return format((Date) obj, toAppendTo);
} else if (obj instanceof Calendar) {
@@ -393,13 +393,13 @@ public class FastDatePrinter implements
* @see org.apache.commons.lang3.time.DatePrinter#format(long)
*/
@Override
- public String format(long millis) {
+ public String format(final long millis) {
Calendar c = newCalendar(); // hard code GregorianCalendar
c.setTimeInMillis(millis);
return applyRulesToString(c);
}
- private String applyRulesToString(Calendar c) {
+ private String applyRulesToString(final Calendar c) {
return applyRules(c, new StringBuffer(mMaxLengthEstimate)).toString();
}
@@ -412,7 +412,7 @@ public class FastDatePrinter implements
* @see org.apache.commons.lang3.time.DatePrinter#format(java.util.Date)
*/
@Override
- public String format(Date date) {
+ public String format(final Date date) {
Calendar c = newCalendar(); // hard code GregorianCalendar
c.setTime(date);
return applyRulesToString(c);
@@ -422,7 +422,7 @@ public class FastDatePrinter implements
* @see org.apache.commons.lang3.time.DatePrinter#format(java.util.Calendar)
*/
@Override
- public String format(Calendar calendar) {
+ public String format(final Calendar calendar) {
return format(calendar, new StringBuffer(mMaxLengthEstimate)).toString();
}
@@ -430,7 +430,7 @@ public class FastDatePrinter implements
* @see org.apache.commons.lang3.time.DatePrinter#format(long, java.lang.StringBuffer)
*/
@Override
- public StringBuffer format(long millis, StringBuffer buf) {
+ public StringBuffer format(final long millis, final StringBuffer buf) {
return format(new Date(millis), buf);
}
@@ -438,7 +438,7 @@ public class FastDatePrinter implements
* @see org.apache.commons.lang3.time.DatePrinter#format(java.util.Date, java.lang.StringBuffer)
*/
@Override
- public StringBuffer format(Date date, StringBuffer buf) {
+ public StringBuffer format(final Date date, final StringBuffer buf) {
Calendar c = newCalendar(); // hard code GregorianCalendar
c.setTime(date);
return applyRules(c, buf);
@@ -448,7 +448,7 @@ public class FastDatePrinter implements
* @see org.apache.commons.lang3.time.DatePrinter#format(java.util.Calendar, java.lang.StringBuffer)
*/
@Override
- public StringBuffer format(Calendar calendar, StringBuffer buf) {
+ public StringBuffer format(final Calendar calendar, final StringBuffer buf) {
return applyRules(calendar, buf);
}
@@ -460,7 +460,7 @@ public class FastDatePrinter implements
* @param buf the buffer to format into
* @return the specified string buffer
*/
- protected StringBuffer applyRules(Calendar calendar, StringBuffer buf) {
+ protected StringBuffer applyRules(final Calendar calendar, final StringBuffer buf) {
for (Rule rule : mRules) {
rule.appendTo(buf, calendar);
}
@@ -515,7 +515,7 @@ public class FastDatePrinter implements
* @return {@code true} if equal
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj instanceof FastDatePrinter == false) {
return false;
}
@@ -555,7 +555,7 @@ public class FastDatePrinter implements
* @throws IOException if there is an IO issue.
* @throws ClassNotFoundException if a class cannot be found.
*/
- private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
+ private void readObject(final ObjectInputStream in) throws IOException, ClassNotFoundException {
in.defaultReadObject();
init();
}
@@ -607,7 +607,7 @@ public class FastDatePrinter implements
*
* @param value the character literal
*/
- CharacterLiteral(char value) {
+ CharacterLiteral(final char value) {
mValue = value;
}
@@ -623,7 +623,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
buffer.append(mValue);
}
}
@@ -640,7 +640,7 @@ public class FastDatePrinter implements
*
* @param value the string literal
*/
- StringLiteral(String value) {
+ StringLiteral(final String value) {
mValue = value;
}
@@ -656,7 +656,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
buffer.append(mValue);
}
}
@@ -675,7 +675,7 @@ public class FastDatePrinter implements
* @param field the field
* @param values the field values
*/
- TextField(int field, String[] values) {
+ TextField(final int field, final String[] values) {
mField = field;
mValues = values;
}
@@ -699,7 +699,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
buffer.append(mValues[calendar.get(mField)]);
}
}
@@ -715,7 +715,7 @@ public class FastDatePrinter implements
*
* @param field the field
*/
- UnpaddedNumberField(int field) {
+ UnpaddedNumberField(final int field) {
mField = field;
}
@@ -731,7 +731,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
appendTo(buffer, calendar.get(mField));
}
@@ -739,7 +739,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public final void appendTo(StringBuffer buffer, int value) {
+ public final void appendTo(final StringBuffer buffer, final int value) {
if (value < 10) {
buffer.append((char)(value + '0'));
} else if (value < 100) {
@@ -777,7 +777,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
appendTo(buffer, calendar.get(Calendar.MONTH) + 1);
}
@@ -785,7 +785,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public final void appendTo(StringBuffer buffer, int value) {
+ public final void appendTo(final StringBuffer buffer, final int value) {
if (value < 10) {
buffer.append((char)(value + '0'));
} else {
@@ -808,7 +808,7 @@ public class FastDatePrinter implements
* @param field the field
* @param size size of the output field
*/
- PaddedNumberField(int field, int size) {
+ PaddedNumberField(final int field, final int size) {
if (size < 3) {
// Should use UnpaddedNumberField or TwoDigitNumberField.
throw new IllegalArgumentException();
@@ -829,7 +829,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
appendTo(buffer, calendar.get(mField));
}
@@ -837,7 +837,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public final void appendTo(StringBuffer buffer, int value) {
+ public final void appendTo(final StringBuffer buffer, final int value) {
if (value < 100) {
for (int i = mSize; --i >= 2; ) {
buffer.append('0');
@@ -871,7 +871,7 @@ public class FastDatePrinter implements
*
* @param field the field
*/
- TwoDigitNumberField(int field) {
+ TwoDigitNumberField(final int field) {
mField = field;
}
@@ -887,7 +887,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
appendTo(buffer, calendar.get(mField));
}
@@ -895,7 +895,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public final void appendTo(StringBuffer buffer, int value) {
+ public final void appendTo(final StringBuffer buffer, final int value) {
if (value < 100) {
buffer.append((char)(value / 10 + '0'));
buffer.append((char)(value % 10 + '0'));
@@ -930,7 +930,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
appendTo(buffer, calendar.get(Calendar.YEAR) % 100);
}
@@ -938,7 +938,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public final void appendTo(StringBuffer buffer, int value) {
+ public final void appendTo(final StringBuffer buffer, final int value) {
buffer.append((char)(value / 10 + '0'));
buffer.append((char)(value % 10 + '0'));
}
@@ -969,7 +969,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
appendTo(buffer, calendar.get(Calendar.MONTH) + 1);
}
@@ -977,7 +977,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public final void appendTo(StringBuffer buffer, int value) {
+ public final void appendTo(final StringBuffer buffer, final int value) {
buffer.append((char)(value / 10 + '0'));
buffer.append((char)(value % 10 + '0'));
}
@@ -995,7 +995,7 @@ public class FastDatePrinter implements
*
* @param rule the rule
*/
- TwelveHourField(NumberRule rule) {
+ TwelveHourField(final NumberRule rule) {
mRule = rule;
}
@@ -1011,7 +1011,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
int value = calendar.get(Calendar.HOUR);
if (value == 0) {
value = calendar.getLeastMaximum(Calendar.HOUR) + 1;
@@ -1023,7 +1023,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, int value) {
+ public void appendTo(final StringBuffer buffer, final int value) {
mRule.appendTo(buffer, value);
}
}
@@ -1040,7 +1040,7 @@ public class FastDatePrinter implements
*
* @param rule the rule
*/
- TwentyFourHourField(NumberRule rule) {
+ TwentyFourHourField(final NumberRule rule) {
mRule = rule;
}
@@ -1056,7 +1056,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
int value = calendar.get(Calendar.HOUR_OF_DAY);
if (value == 0) {
value = calendar.getMaximum(Calendar.HOUR_OF_DAY) + 1;
@@ -1068,7 +1068,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, int value) {
+ public void appendTo(final StringBuffer buffer, final int value) {
mRule.appendTo(buffer, value);
}
}
@@ -1086,7 +1086,7 @@ public class FastDatePrinter implements
* @param locale the locale to use
* @return the textual name of the time zone
*/
- static String getTimeZoneDisplay(TimeZone tz, boolean daylight, int style, Locale locale) {
+ static String getTimeZoneDisplay(final TimeZone tz, final boolean daylight, final int style, final Locale locale) {
TimeZoneDisplayKey key = new TimeZoneDisplayKey(tz, daylight, style, locale);
String value = cTimeZoneDisplayCache.get(key);
if (value == null) {
@@ -1116,7 +1116,7 @@ public class FastDatePrinter implements
* @param locale the locale
* @param style the style
*/
- TimeZoneNameRule(TimeZone timeZone, Locale locale, int style) {
+ TimeZoneNameRule(final TimeZone timeZone, final Locale locale, final int style) {
mLocale = locale;
mStyle = style;
@@ -1139,7 +1139,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
TimeZone zone = calendar.getTimeZone();
if (zone.useDaylightTime()
&& calendar.get(Calendar.DST_OFFSET) != 0) {
@@ -1165,7 +1165,7 @@ public class FastDatePrinter implements
*
* @param colon add colon between HH and MM in the output if {@code true}
*/
- TimeZoneNumberRule(boolean colon) {
+ TimeZoneNumberRule(final boolean colon) {
mColon = colon;
}
@@ -1181,7 +1181,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public void appendTo(StringBuffer buffer, Calendar calendar) {
+ public void appendTo(final StringBuffer buffer, final Calendar calendar) {
int offset = calendar.get(Calendar.ZONE_OFFSET) + calendar.get(Calendar.DST_OFFSET);
if (offset < 0) {
@@ -1222,8 +1222,8 @@ public class FastDatePrinter implements
* @param style the timezone style
* @param locale the timezone locale
*/
- TimeZoneDisplayKey(TimeZone timeZone,
- boolean daylight, int style, Locale locale) {
+ TimeZoneDisplayKey(final TimeZone timeZone,
+ final boolean daylight, int style, final Locale locale) {
mTimeZone = timeZone;
if (daylight) {
style |= 0x80000000;
@@ -1244,7 +1244,7 @@ public class FastDatePrinter implements
* {@inheritDoc}
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (this == obj) {
return true;
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java Tue Jan 22 07:07:42 2013
@@ -66,7 +66,7 @@ abstract class FormatCache<F extends For
* @throws IllegalArgumentException if pattern is invalid
* or <code>null</code>
*/
- public F getInstance(String pattern, TimeZone timeZone, Locale locale) {
+ public F getInstance(final String pattern, TimeZone timeZone, Locale locale) {
if (pattern == null) {
throw new NullPointerException("pattern must not be null");
}
@@ -116,7 +116,7 @@ abstract class FormatCache<F extends For
* @throws IllegalArgumentException if the Locale has no date/time
* pattern defined
*/
- public F getDateTimeInstance(Integer dateStyle, Integer timeStyle, TimeZone timeZone, Locale locale) {
+ public F getDateTimeInstance(final Integer dateStyle, final Integer timeStyle, final TimeZone timeZone, Locale locale) {
if (locale == null) {
locale = Locale.getDefault();
}
@@ -133,7 +133,7 @@ abstract class FormatCache<F extends For
* @return a localized standard date/time format
* @throws IllegalArgumentException if the Locale has no date/time pattern defined
*/
- public static String getPatternForStyle(Integer dateStyle, Integer timeStyle, Locale locale) {
+ public static String getPatternForStyle(final Integer dateStyle, final Integer timeStyle, final Locale locale) {
MultipartKey key = new MultipartKey(dateStyle, timeStyle, locale);
String pattern = cDateTimeInstanceCache.get(key);
@@ -176,7 +176,7 @@ abstract class FormatCache<F extends For
* Constructs an instance of <code>MultipartKey</code> to hold the specified objects.
* @param keys the set of objects that make up the key. Each key may be null.
*/
- public MultipartKey(Object... keys) {
+ public MultipartKey(final Object... keys) {
this.keys = keys;
}
@@ -184,7 +184,7 @@ abstract class FormatCache<F extends For
* {@inheritDoc}
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
// Eliminate the usual boilerplate because
// this inner static class is only used in a generic ConcurrentHashMap
// which will not compare against other Object types
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java Tue Jan 22 07:07:42 2013
@@ -54,7 +54,7 @@ public final class ImmutablePair<L, R> e
* @param right the right element, may be null
* @return a pair formed from the two parameters, not null
*/
- public static <L, R> ImmutablePair<L, R> of(L left, R right) {
+ public static <L, R> ImmutablePair<L, R> of(final L left, final R right) {
return new ImmutablePair<L, R>(left, right);
}
@@ -64,7 +64,7 @@ public final class ImmutablePair<L, R> e
* @param left the left value, may be null
* @param right the right value, may be null
*/
- public ImmutablePair(L left, R right) {
+ public ImmutablePair(final L left, final R right) {
super();
this.left = left;
this.right = right;
@@ -97,7 +97,7 @@ public final class ImmutablePair<L, R> e
* @throws UnsupportedOperationException as this operation is not supported
*/
@Override
- public R setValue(R value) {
+ public R setValue(final R value) {
throw new UnsupportedOperationException();
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java Tue Jan 22 07:07:42 2013
@@ -58,7 +58,7 @@ public final class ImmutableTriple<L, M,
* @param right the right element, may be null
* @return a triple formed from the three parameters, not null
*/
- public static <L, M, R> ImmutableTriple<L, M, R> of(L left, M middle, R right) {
+ public static <L, M, R> ImmutableTriple<L, M, R> of(final L left, final M middle, final R right) {
return new ImmutableTriple<L, M, R>(left, middle, right);
}
@@ -69,7 +69,7 @@ public final class ImmutableTriple<L, M,
* @param middle the middle value, may be null
* @param right the right value, may be null
*/
- public ImmutableTriple(L left, M middle, R right) {
+ public ImmutableTriple(final L left, final M middle, final R right) {
super();
this.left = left;
this.middle = middle;
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutablePair<L, R> extends P
* @param right the right element, may be null
* @return a pair formed from the two parameters, not null
*/
- public static <L, R> MutablePair<L, R> of(L left, R right) {
+ public static <L, R> MutablePair<L, R> of(final L left, final R right) {
return new MutablePair<L, R>(left, right);
}
@@ -66,7 +66,7 @@ public class MutablePair<L, R> extends P
* @param left the left value, may be null
* @param right the right value, may be null
*/
- public MutablePair(L left, R right) {
+ public MutablePair(final L left, final R right) {
super();
this.left = left;
this.right = right;
@@ -86,7 +86,7 @@ public class MutablePair<L, R> extends P
*
* @param left the new value of the left element, may be null
*/
- public void setLeft(L left) {
+ public void setLeft(final L left) {
this.left = left;
}
@@ -103,7 +103,7 @@ public class MutablePair<L, R> extends P
*
* @param right the new value of the right element, may be null
*/
- public void setRight(R right) {
+ public void setRight(final R right) {
this.right = right;
}
@@ -115,7 +115,7 @@ public class MutablePair<L, R> extends P
* @return the old value for the right element
*/
@Override
- public R setValue(R value) {
+ public R setValue(final R value) {
R result = getRight();
setRight(value);
return result;
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java Tue Jan 22 07:07:42 2013
@@ -53,7 +53,7 @@ public class MutableTriple<L, M, R> exte
* @param right the right element, may be null
* @return a triple formed from the three parameters, not null
*/
- public static <L, M, R> MutableTriple<L, M, R> of(L left, M middle, R right) {
+ public static <L, M, R> MutableTriple<L, M, R> of(final L left, final M middle, final R right) {
return new MutableTriple<L, M, R>(left, middle, right);
}
@@ -71,7 +71,7 @@ public class MutableTriple<L, M, R> exte
* @param middle the middle value, may be null
* @param right the right value, may be null
*/
- public MutableTriple(L left, M middle, R right) {
+ public MutableTriple(final L left, final M middle, final R right) {
super();
this.left = left;
this.middle = middle;
@@ -92,7 +92,7 @@ public class MutableTriple<L, M, R> exte
*
* @param left the new value of the left element, may be null
*/
- public void setLeft(L left) {
+ public void setLeft(final L left) {
this.left = left;
}
@@ -109,7 +109,7 @@ public class MutableTriple<L, M, R> exte
*
* @param middle the new value of the middle element, may be null
*/
- public void setMiddle(M middle) {
+ public void setMiddle(final M middle) {
this.middle = middle;
}
@@ -126,7 +126,7 @@ public class MutableTriple<L, M, R> exte
*
* @param right the new value of the right element, may be null
*/
- public void setRight(R right) {
+ public void setRight(final R right) {
this.right = right;
}
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Pair.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Pair.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Pair.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Pair.java Tue Jan 22 07:07:42 2013
@@ -56,7 +56,7 @@ public abstract class Pair<L, R> impleme
* @param right the right element, may be null
* @return a pair formed from the two parameters, not null
*/
- public static <L, R> Pair<L, R> of(L left, R right) {
+ public static <L, R> Pair<L, R> of(final L left, final R right) {
return new ImmutablePair<L, R>(left, right);
}
@@ -114,7 +114,7 @@ public abstract class Pair<L, R> impleme
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(Pair<L, R> other) {
+ public int compareTo(final Pair<L, R> other) {
return new CompareToBuilder().append(getLeft(), other.getLeft())
.append(getRight(), other.getRight()).toComparison();
}
@@ -126,7 +126,7 @@ public abstract class Pair<L, R> impleme
* @return true if the elements of the pair are equal
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj == this) {
return true;
}
@@ -172,7 +172,7 @@ public abstract class Pair<L, R> impleme
* @param format the format string, optionally containing {@code %1$s} and {@code %2$s}, not null
* @return the formatted string, not null
*/
- public String toString(String format) {
+ public String toString(final String format) {
return String.format(format, getLeft(), getRight());
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Triple.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Triple.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Triple.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/tuple/Triple.java Tue Jan 22 07:07:42 2013
@@ -56,7 +56,7 @@ public abstract class Triple<L, M, R> im
* @param right the right element, may be null
* @return a triple formed from the three parameters, not null
*/
- public static <L, M, R> Triple<L, M, R> of(L left, M middle, R right) {
+ public static <L, M, R> Triple<L, M, R> of(final L left, final M middle, final R right) {
return new ImmutableTriple<L, M, R>(left, middle, right);
}
@@ -92,7 +92,7 @@ public abstract class Triple<L, M, R> im
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(Triple<L, M, R> other) {
+ public int compareTo(final Triple<L, M, R> other) {
return new CompareToBuilder().append(getLeft(), other.getLeft())
.append(getMiddle(), other.getMiddle())
.append(getRight(), other.getRight()).toComparison();
@@ -105,7 +105,7 @@ public abstract class Triple<L, M, R> im
* @return true if the elements of the triple are equal
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj == this) {
return true;
}
@@ -152,7 +152,7 @@ public abstract class Triple<L, M, R> im
* @param format the format string, optionally containing {@code %1$s}, {@code %2$s} and {@code %3$s}, not null
* @return the formatted string, not null
*/
- public String toString(String format) {
+ public String toString(final String format) {
return String.format(format, getLeft(), getMiddle(), getRight());
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -452,7 +452,7 @@ public class AnnotationUtilsTest {
InvocationHandler generatedTestInvocationHandler = new InvocationHandler() {
@Override
- public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
+ public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable {
if ("equals".equals(method.getName()) && method.getParameterTypes().length == 1) {
return Boolean.valueOf(proxy == args[0]);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -87,7 +87,7 @@ public class ArrayUtilsTest {
}
//-----------------------------------------------------------------------
- private void assertIsEquals(Object array1, Object array2, Object array3) {
+ private void assertIsEquals(final Object array1, final Object array2, final Object array3) {
assertTrue(ArrayUtils.isEquals(array1, array1));
assertTrue(ArrayUtils.isEquals(array2, array2));
assertTrue(ArrayUtils.isEquals(array3, array3));
@@ -254,11 +254,11 @@ public class ArrayUtilsTest {
return "bar";
}
@Override
- public Object setValue(Object value) {
+ public Object setValue(final Object value) {
throw new UnsupportedOperationException();
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
throw new UnsupportedOperationException();
}
@Override
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharEncodingTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharEncodingTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharEncodingTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharEncodingTest.java Tue Jan 22 07:07:42 2013
@@ -33,7 +33,7 @@ import org.junit.Test;
*/
public class CharEncodingTest {
- private void assertSupportedEncoding(String name) {
+ private void assertSupportedEncoding(final String name) {
assertTrue("Encoding should be supported: " + name, CharEncoding.isSupported(name));
}
@@ -106,7 +106,7 @@ public class CharEncodingTest {
}
}
- void warn(String msg) {
+ void warn(final String msg) {
System.err.println(msg);
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java Tue Jan 22 07:07:42 2013
@@ -71,7 +71,7 @@ public class CharUtilsPerfRun {
}
}
- public static void main(String[] args) {
+ public static void main(final String[] args) {
new CharUtilsPerfRun().run();
}
@@ -122,7 +122,7 @@ public class CharUtilsPerfRun {
this.printlnTotal("run_CharSet", start);
}
- private int run_CharSet(int loopCount) {
+ private int run_CharSet(final int loopCount) {
int t = 0;
for (int i = 0; i < loopCount; i++) {
for (char ch : CHAR_SAMPLES) {
@@ -133,7 +133,7 @@ public class CharUtilsPerfRun {
return t;
}
- private int run_CharUtils_isAsciiNumeric(int loopCount) {
+ private int run_CharUtils_isAsciiNumeric(final int loopCount) {
int t = 0;
for (int i = 0; i < loopCount; i++) {
for (char ch : CHAR_SAMPLES) {
@@ -144,7 +144,7 @@ public class CharUtilsPerfRun {
return t;
}
- private int run_inlined_CharUtils_isAsciiNumeric(int loopCount) {
+ private int run_inlined_CharUtils_isAsciiNumeric(final int loopCount) {
int t = 0;
for (int i = 0; i < loopCount; i++) {
for (char ch : CHAR_SAMPLES) {
@@ -155,7 +155,7 @@ public class CharUtilsPerfRun {
return t;
}
- private void printlnTotal(String prefix, long start) {
+ private void printlnTotal(final String prefix, final long start) {
long total = System.currentTimeMillis() - start;
System.out.println(prefix + ": " + NumberFormat.getInstance().format(total) + " milliseconds.");
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -1042,11 +1042,11 @@ public class ClassUtilsTest {
assertEquals( boolean.class, ClassUtils.getClass( "boolean" ) );
}
- private void assertGetClassReturnsClass( Class<?> c ) throws Exception {
+ private void assertGetClassReturnsClass( final Class<?> c ) throws Exception {
assertEquals( c, ClassUtils.getClass( c.getName() ) );
}
- private void assertGetClassThrowsException( String className, Class<?> exceptionType ) throws Exception {
+ private void assertGetClassThrowsException( final String className, final Class<?> exceptionType ) throws Exception {
try {
ClassUtils.getClass( className );
fail( "ClassUtils.getClass() should fail with an exception of type " + exceptionType.getName() + " when given class name \"" + className + "\"." );
@@ -1056,11 +1056,11 @@ public class ClassUtilsTest {
}
}
- private void assertGetClassThrowsNullPointerException( String className ) throws Exception {
+ private void assertGetClassThrowsNullPointerException( final String className ) throws Exception {
assertGetClassThrowsException( className, NullPointerException.class );
}
- private void assertGetClassThrowsClassNotFound( String className ) throws Exception {
+ private void assertGetClassThrowsClassNotFound( final String className ) throws Exception {
assertGetClassThrowsException( className, ClassNotFoundException.class );
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ConversionTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ConversionTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ConversionTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ConversionTest.java Tue Jan 22 07:07:42 2013
@@ -510,7 +510,7 @@ public class ConversionTest {
}
}
- static String dbgPrint(boolean[] src) {
+ static String dbgPrint(final boolean[] src) {
StringBuilder sb = new StringBuilder();
for (boolean e : src) {
if (e) {
@@ -524,7 +524,7 @@ public class ConversionTest {
}
// org.junit.Assert(boolean[], boolean[]) does not exist in JUnit 4.2
- static void assertBinaryEquals(boolean[] expected, boolean[] actual) {
+ static void assertBinaryEquals(final boolean[] expected, final boolean[] actual) {
assertEquals(expected.length, actual.length);
for (int i = 0; i < expected.length; i++ ) {
try {
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -252,7 +252,7 @@ public class EnumUtilsTest {
assertArrayEquals(EnumUtils.generateBitVectors(Traffic.class, Traffic.RED, Traffic.AMBER, Traffic.GREEN, Traffic.GREEN), 7L);
}
- private void assertArrayEquals(long[] actual, long... expected) {
+ private void assertArrayEquals(final long[] actual, final long... expected) {
Assert.assertArrayEquals(expected, actual);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/HashSetvBitSetTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/HashSetvBitSetTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/HashSetvBitSetTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/HashSetvBitSetTest.java Tue Jan 22 07:07:42 2013
@@ -48,7 +48,7 @@ public class HashSetvBitSetTest {
/**
* @return bitSet - HashSet
*/
- private long printTimes(int count) {
+ private long printTimes(final int count) {
long hashSet = timeHashSet(count);
long bitSet = timeBitSet(count);
// If percent is less than 100, then bitset is faster
@@ -56,7 +56,7 @@ public class HashSetvBitSetTest {
return bitSet - hashSet;
}
- private static long timeHashSet(int count) {
+ private static long timeHashSet(final int count) {
int [] result = new int[0];
long start = System.nanoTime();
for (int i = 0; i < LOOPS; i++) {
@@ -67,7 +67,7 @@ public class HashSetvBitSetTest {
return elapsed;
}
- private static long timeBitSet(int count) {
+ private static long timeBitSet(final int count) {
int [] result = new int[0];
long start = System.nanoTime();
for (int i = 0; i < LOOPS; i++) {
@@ -79,7 +79,7 @@ public class HashSetvBitSetTest {
}
@SuppressWarnings("boxing")
- private static int[] testHashSet(int count) {
+ private static int[] testHashSet(final int count) {
HashSet<Integer> toRemove = new HashSet<Integer>();
int found = 0;
for (int i = 0; i < count; i++) {
@@ -88,7 +88,7 @@ public class HashSetvBitSetTest {
return extractIndices(toRemove);
}
- private static int[] testBitSet(int count) {
+ private static int[] testBitSet(final int count) {
BitSet toRemove = new BitSet();
int found = 0;
for (int i = 0; i < count; i++) {
@@ -98,7 +98,7 @@ public class HashSetvBitSetTest {
}
- private static int[] extractIndices(HashSet<Integer> coll) {
+ private static int[] extractIndices(final HashSet<Integer> coll) {
int[] result = new int[coll.size()];
int i = 0;
for (Integer index : coll) {
@@ -107,7 +107,7 @@ public class HashSetvBitSetTest {
return result;
}
- private static int[] extractIndices(BitSet coll) {
+ private static int[] extractIndices(final BitSet coll) {
int[] result = new int[coll.cardinality()];
int i = 0;
int j=0;
@@ -135,7 +135,7 @@ public class HashSetvBitSetTest {
Assert.assertTrue(timeDiff <= 0);
}
- private long printTimes(int arraySize, int bitSetSize) {
+ private long printTimes(final int arraySize, final int bitSetSize) {
int[] array = new int[arraySize];
BitSet remove = new BitSet();
for (int i = 0; i < bitSetSize; i++) {
@@ -148,7 +148,7 @@ public class HashSetvBitSetTest {
return bitSet - extract;
}
- private long timeBitSetRemoveAll(int[] array, BitSet toRemove) {
+ private long timeBitSetRemoveAll(final int[] array, final BitSet toRemove) {
int[] output = new int[0];
long start = System.nanoTime();
for(int i = 0; i < LOOPS2; i++){
@@ -159,7 +159,7 @@ public class HashSetvBitSetTest {
return end - start;
}
- private long timeExtractRemoveAll(int[] array, BitSet toRemove) {
+ private long timeExtractRemoveAll(final int[] array, final BitSet toRemove) {
int[] output = new int[0];
long start = System.nanoTime();
for(int i = 0; i < LOOPS2; i++){
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/LocaleUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/LocaleUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/LocaleUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/LocaleUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -80,7 +80,7 @@ public class LocaleUtilsTest {
*
* @param language the language string
*/
- private void assertValidToLocale(String language) {
+ private void assertValidToLocale(final String language) {
Locale locale = LocaleUtils.toLocale(language);
assertNotNull("valid locale", locale);
assertEquals(language, locale.getLanguage());
@@ -96,7 +96,7 @@ public class LocaleUtilsTest {
* @param language of the resulting Locale
* @param country of the resulting Locale
*/
- private void assertValidToLocale(String localeString, String language, String country) {
+ private void assertValidToLocale(final String localeString, final String language, final String country) {
Locale locale = LocaleUtils.toLocale(localeString);
assertNotNull("valid locale", locale);
assertEquals(language, locale.getLanguage());
@@ -114,8 +114,8 @@ public class LocaleUtilsTest {
* @param variant of the resulting Locale
*/
private void assertValidToLocale(
- String localeString, String language,
- String country, String variant) {
+ final String localeString, final String language,
+ final String country, final String variant) {
Locale locale = LocaleUtils.toLocale(localeString);
assertNotNull("valid locale", locale);
assertEquals(language, locale.getLanguage());
@@ -240,7 +240,7 @@ public class LocaleUtilsTest {
* @param defaultLocale the input default locale
* @param expected expected results
*/
- private void assertLocaleLookupList(Locale locale, Locale defaultLocale, Locale[] expected) {
+ private void assertLocaleLookupList(final Locale locale, final Locale defaultLocale, final Locale[] expected) {
List<Locale> localeList = defaultLocale == null ?
LocaleUtils.localeLookupList(locale) :
LocaleUtils.localeLookupList(locale, defaultLocale);
@@ -387,7 +387,7 @@ public class LocaleUtilsTest {
* @param country
* @param languages array of languages that should be returned
*/
- private void assertLanguageByCountry(String country, String[] languages) {
+ private void assertLanguageByCountry(final String country, final String[] languages) {
List<Locale> list = LocaleUtils.languagesByCountry(country);
List<Locale> list2 = LocaleUtils.languagesByCountry(country);
assertNotNull(list);
@@ -438,7 +438,7 @@ public class LocaleUtilsTest {
* @param language
* @param countries array of countries that should be returned
*/
- private void assertCountriesByLanguage(String language, String[] countries) {
+ private void assertCountriesByLanguage(final String language, final String[] countries) {
List<Locale> list = LocaleUtils.countriesByLanguage(language);
List<Locale> list2 = LocaleUtils.countriesByLanguage(language);
assertNotNull(list);
@@ -481,7 +481,7 @@ public class LocaleUtilsTest {
/**
* @param coll the collection to check
*/
- private static void assertUnmodifiableCollection(Collection<?> coll) {
+ private static void assertUnmodifiableCollection(final Collection<?> coll) {
try {
coll.add(null);
fail();
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -560,14 +560,14 @@ public class ObjectUtilsTest {
*
* @param value
*/
- public NonComparableCharSequence(String value) {
+ public NonComparableCharSequence(final String value) {
super();
Validate.notNull(value);
this.value = value;
}
@Override
- public char charAt(int arg0) {
+ public char charAt(final int arg0) {
return value.charAt(arg0);
}
@@ -577,7 +577,7 @@ public class ObjectUtilsTest {
}
@Override
- public CharSequence subSequence(int arg0, int arg1) {
+ public CharSequence subSequence(final int arg0, final int arg1) {
return value.subSequence(arg0, arg1);
}
@@ -590,7 +590,7 @@ public class ObjectUtilsTest {
static final class CharSequenceComparator implements Comparator<CharSequence> {
@Override
- public int compare(CharSequence o1, CharSequence o2) {
+ public int compare(final CharSequence o1, final CharSequence o2) {
return o1.toString().compareTo(o2.toString());
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RandomStringUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RandomStringUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RandomStringUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RandomStringUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -319,7 +319,7 @@ public class RandomStringUtilsTest {
* @param observed array of observed frequency counts
* @param expected array of expected frequency counts
*/
- private double chiSquare(int[] expected, int[] observed) {
+ private double chiSquare(final int[] expected, final int[] observed) {
double sumSq = 0.0d;
double dev = 0.0d;
for (int i = 0; i < observed.length; i++) {
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java Tue Jan 22 07:07:42 2013
@@ -68,7 +68,7 @@ public class RangeTest {
Comparable c =
new Comparable() {
@Override
- public int compareTo(Object other) {
+ public int compareTo(final Object other) {
return 1;
}
};
@@ -82,7 +82,7 @@ public class RangeTest {
public void testIsWithCompare(){
Comparator<Integer> c = new Comparator<Integer>(){
@Override
- public int compare(Integer o1, Integer o2) {
+ public int compare(final Integer o1, final Integer o2) {
return 0; // all integers are equal
}
};
@@ -101,7 +101,7 @@ public class RangeTest {
// TODO add tests with a better comparator
Comparator<Integer> c = new Comparator<Integer>(){
@Override
- public int compare(Integer o1, Integer o2) {
+ public int compare(final Integer o1, final Integer o2) {
return 0; // all integers are equal
}
};
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SerializationUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SerializationUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SerializationUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SerializationUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -175,7 +175,7 @@ public class SerializationUtilsTest {
// in the finally block
OutputStream streamTest = new OutputStream() {
@Override
- public void write(int arg0) throws IOException {
+ public void write(final int arg0) throws IOException {
throw new IOException(SERIALIZE_IO_EXCEPTION_MESSAGE);
}
};
@@ -420,7 +420,7 @@ public class SerializationUtilsTest {
class ClassNotFoundSerialization implements Serializable
{
- private void readObject(ObjectInputStream in) throws ClassNotFoundException {
+ private void readObject(final ObjectInputStream in) throws ClassNotFoundException {
throw new ClassNotFoundException(SerializationUtilsTest.CLASS_NOT_FOUND_MESSAGE);
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -106,11 +106,11 @@ public class StringEscapeUtilsTest {
assertEquals(expected, actual);
}
- private void assertEscapeJava(String escaped, String original) throws IOException {
+ private void assertEscapeJava(final String escaped, final String original) throws IOException {
assertEscapeJava(null, escaped, original);
}
- private void assertEscapeJava(String message, String expected, String original) throws IOException {
+ private void assertEscapeJava(String message, final String expected, final String original) throws IOException {
String converted = StringEscapeUtils.escapeJava(original);
message = "escapeJava(String) failed" + (message == null ? "" : (": " + message));
assertEquals(message, expected, converted);
@@ -155,11 +155,11 @@ public class StringEscapeUtilsTest {
assertUnescapeJava("Unicode as final character", "\uABCD", "\\uabcd");
}
- private void assertUnescapeJava(String unescaped, String original) throws IOException {
+ private void assertUnescapeJava(final String unescaped, final String original) throws IOException {
assertUnescapeJava(null, unescaped, original);
}
- private void assertUnescapeJava(String message, String unescaped, String original) throws IOException {
+ private void assertUnescapeJava(final String message, final String unescaped, final String original) throws IOException {
String expected = unescaped;
String actual = StringEscapeUtils.unescapeJava(original);
@@ -416,7 +416,7 @@ public class StringEscapeUtilsTest {
checkCsvEscapeWriter("", "");
}
- private void checkCsvEscapeWriter(String expected, String value) {
+ private void checkCsvEscapeWriter(final String expected, final String value) {
try {
StringWriter writer = new StringWriter();
StringEscapeUtils.ESCAPE_CSV.translate(value, writer);
@@ -452,7 +452,7 @@ public class StringEscapeUtilsTest {
checkCsvUnescapeWriter("\"foo.bar\"", "\"foo.bar\"");
}
- private void checkCsvUnescapeWriter(String expected, String value) {
+ private void checkCsvUnescapeWriter(final String expected, final String value) {
try {
StringWriter writer = new StringWriter();
StringEscapeUtils.UNESCAPE_CSV.translate(value, writer);
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java Tue Jan 22 07:07:42 2013
@@ -468,12 +468,12 @@ public class StringUtilsEqualsIndexOfTes
private static class CustomCharSequence implements CharSequence {
private final CharSequence seq;
- public CustomCharSequence(CharSequence seq) {
+ public CustomCharSequence(final CharSequence seq) {
this.seq = seq;
}
@Override
- public char charAt(int index) {
+ public char charAt(final int index) {
return seq.charAt(index);
}
@@ -483,12 +483,12 @@ public class StringUtilsEqualsIndexOfTes
}
@Override
- public CharSequence subSequence(int start, int end) {
+ public CharSequence subSequence(final int start, final int end) {
return new CustomCharSequence(seq.subSequence(start, end));
}
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj == null || !(obj instanceof CustomCharSequence)) {
return false;
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -438,7 +438,7 @@ public class StringUtilsTest {
}
}
- private void innerTestSplit(char separator, String sepStr, char noMatch) {
+ private void innerTestSplit(final char separator, final String sepStr, final char noMatch) {
String msg = "Failed on separator hex(" + Integer.toHexString(separator) +
"), noMatch hex(" + Integer.toHexString(noMatch) + "), sepStr(" + sepStr + ")";
@@ -902,7 +902,7 @@ public class StringUtilsTest {
}
- private void innerTestSplitPreserveAllTokens(char separator, String sepStr, char noMatch) {
+ private void innerTestSplitPreserveAllTokens(final char separator, final String sepStr, final char noMatch) {
String msg = "Failed on separator hex(" + Integer.toHexString(separator) +
"), noMatch hex(" + Integer.toHexString(noMatch) + "), sepStr(" + sepStr + ")";
@@ -1706,7 +1706,7 @@ public class StringUtilsTest {
assertAbbreviateWithOffset("...ijklmno", Integer.MAX_VALUE, 10);
}
- private void assertAbbreviateWithOffset(String expected, int offset, int maxWidth) {
+ private void assertAbbreviateWithOffset(final String expected, final int offset, final int maxWidth) {
String abcdefghijklmno = "abcdefghijklmno";
String message = "abbreviate(String,int,int) failed";
String actual = StringUtils.abbreviate(abcdefghijklmno, offset, maxWidth);
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java Tue Jan 22 07:07:42 2013
@@ -34,11 +34,11 @@ public class CompareToBuilderTest {
static class TestObject implements Comparable<TestObject> {
private int a;
- public TestObject(int a) {
+ public TestObject(final int a) {
this.a = a;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == this) {
return true;
}
@@ -54,7 +54,7 @@ public class CompareToBuilderTest {
return a;
}
- public void setA(int a) {
+ public void setA(final int a) {
this.a = a;
}
@@ -62,7 +62,7 @@ public class CompareToBuilderTest {
return a;
}
@Override
- public int compareTo(TestObject rhs) {
+ public int compareTo(final TestObject rhs) {
return a < rhs.a ? -1 : a > rhs.a ? +1 : 0;
}
}
@@ -72,12 +72,12 @@ public class CompareToBuilderTest {
public TestSubObject() {
super(0);
}
- public TestSubObject(int a, int b) {
+ public TestSubObject(final int a, final int b) {
super(a);
this.b = b;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == this) {
return true;
}
@@ -92,7 +92,7 @@ public class CompareToBuilderTest {
static class TestTransientSubObject extends TestObject {
@SuppressWarnings("unused")
private transient int t;
- public TestTransientSubObject(int a, int t) {
+ public TestTransientSubObject(final int a, final int t) {
super(a);
this.t = t;
}
@@ -166,7 +166,7 @@ public class CompareToBuilderTest {
assertXYZCompareOrder(x, y, z, true, null);
}
- private void assertXYZCompareOrder(Object x, Object y, Object z, boolean testTransients, String[] excludeFields) {
+ private void assertXYZCompareOrder(final Object x, final Object y, final Object z, final boolean testTransients, final String[] excludeFields) {
assertTrue(0 == CompareToBuilder.reflectionCompare(x, x, testTransients, null, excludeFields));
assertTrue(0 == CompareToBuilder.reflectionCompare(y, y, testTransients, null, excludeFields));
assertTrue(0 == CompareToBuilder.reflectionCompare(z, z, testTransients, null, excludeFields));
@@ -180,7 +180,7 @@ public class CompareToBuilderTest {
assertTrue(0 < CompareToBuilder.reflectionCompare(z, y, testTransients, null, excludeFields));
}
- private void testReflectionHierarchyCompare(boolean testTransients, String[] excludeFields) {
+ private void testReflectionHierarchyCompare(final boolean testTransients, final String[] excludeFields) {
TestObject to1 = new TestObject(1);
TestObject to2 = new TestObject(2);
TestObject to3 = new TestObject(3);
@@ -212,7 +212,7 @@ public class CompareToBuilderTest {
* @param testTransients Whether to include transients in the comparison
* @param excludeFields fields to exclude
*/
- private void assertReflectionCompareContract(Object x, Object y, Object z, boolean testTransients, String[] excludeFields) {
+ private void assertReflectionCompareContract(final Object x, final Object y, final Object z, final boolean testTransients, final String[] excludeFields) {
// signum
assertTrue(reflectionCompareSignum(x, y, testTransients, excludeFields) == -reflectionCompareSignum(y, x, testTransients, excludeFields));
@@ -242,7 +242,7 @@ public class CompareToBuilderTest {
* @param excludeFields fields to exclude
* @return int The signum
*/
- private int reflectionCompareSignum(Object lhs, Object rhs, boolean testTransients, String[] excludeFields) {
+ private int reflectionCompareSignum(final Object lhs, final Object rhs, final boolean testTransients, final String[] excludeFields) {
return BigInteger.valueOf(CompareToBuilder.reflectionCompare(lhs, rhs, testTransients)).signum();
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java Tue Jan 22 07:07:42 2013
@@ -38,11 +38,11 @@ public class EqualsBuilderTest {
private int a;
public TestObject() {
}
- public TestObject(int a) {
+ public TestObject(final int a) {
this.a = a;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == null) { return false; }
if (o == this) { return true; }
if (o.getClass() != getClass()) {
@@ -58,7 +58,7 @@ public class EqualsBuilderTest {
return a;
}
- public void setA(int a) {
+ public void setA(final int a) {
this.a = a;
}
@@ -72,12 +72,12 @@ public class EqualsBuilderTest {
public TestSubObject() {
super(0);
}
- public TestSubObject(int a, int b) {
+ public TestSubObject(final int a, final int b) {
super(a);
this.b = b;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == null) { return false; }
if (o == this) { return true; }
if (o.getClass() != getClass()) {
@@ -93,7 +93,7 @@ public class EqualsBuilderTest {
return b *17 + super.hashCode();
}
- public void setB(int b) {
+ public void setB(final int b) {
this.b = b;
}
@@ -103,7 +103,7 @@ public class EqualsBuilderTest {
}
static class TestEmptySubObject extends TestObject {
- public TestEmptySubObject(int a) {
+ public TestEmptySubObject(final int a) {
super(a);
}
}
@@ -111,7 +111,7 @@ public class EqualsBuilderTest {
static class TestTSubObject extends TestObject {
@SuppressWarnings("unused")
private transient int t;
- public TestTSubObject(int a, int t) {
+ public TestTSubObject(final int a, final int t) {
super(a);
this.t = t;
}
@@ -120,7 +120,7 @@ public class EqualsBuilderTest {
static class TestTTSubObject extends TestTSubObject {
@SuppressWarnings("unused")
private transient int tt;
- public TestTTSubObject(int a, int t, int tt) {
+ public TestTTSubObject(final int a, final int t, final int tt) {
super(a, t);
this.tt = tt;
}
@@ -129,7 +129,7 @@ public class EqualsBuilderTest {
static class TestTTLeafObject extends TestTTSubObject {
@SuppressWarnings("unused")
private final int leafValue;
- public TestTTLeafObject(int a, int t, int tt, int leafValue) {
+ public TestTTLeafObject(final int a, final int t, final int tt, final int leafValue) {
super(a, t, tt);
this.leafValue = leafValue;
}
@@ -137,13 +137,13 @@ public class EqualsBuilderTest {
static class TestTSubObject2 extends TestObject {
private transient int t;
- public TestTSubObject2(int a, int t) {
+ public TestTSubObject2(final int a, final int t) {
super(a);
}
public int getT() {
return t;
}
- public void setT(int t) {
+ public void setT(final int t) {
this.t = t;
}
}
@@ -176,7 +176,7 @@ public class EqualsBuilderTest {
assertTrue(!EqualsBuilder.reflectionEquals(new TestTTLeafObject(0, 2, 3, 4), new TestTTLeafObject(1, 2, 3, 4), true));
}
- private void testReflectionHierarchyEquals(boolean testTransients) {
+ private void testReflectionHierarchyEquals(final boolean testTransients) {
TestObject to1 = new TestObject(4);
TestObject to1Bis = new TestObject(4);
TestObject to1Ter = new TestObject(4);
@@ -249,12 +249,12 @@ public class EqualsBuilderTest {
* @param testTransients whether to test transient instance variables
*/
private void testReflectionEqualsEquivalenceRelationship(
- TestObject to,
- TestObject toBis,
- TestObject toTer,
- TestObject to2,
- TestObject oToChange,
- boolean testTransients) {
+ final TestObject to,
+ final TestObject toBis,
+ final TestObject toTer,
+ final TestObject to2,
+ final TestObject oToChange,
+ final boolean testTransients) {
// reflection test
assertTrue(EqualsBuilder.reflectionEquals(to, to, testTransients));
@@ -940,12 +940,12 @@ public class EqualsBuilderTest {
public static class TestACanEqualB {
private final int a;
- public TestACanEqualB(int a) {
+ public TestACanEqualB(final int a) {
this.a = a;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == this) {
return true;
}
@@ -971,12 +971,12 @@ public class EqualsBuilderTest {
public static class TestBCanEqualA {
private final int b;
- public TestBCanEqualA(int b) {
+ public TestBCanEqualA(final int b) {
this.b = b;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == this) {
return true;
}
@@ -1071,7 +1071,7 @@ public class EqualsBuilderTest {
@SuppressWarnings("unused")
private final TestObject three;
- public TestObjectWithMultipleFields(int one, int two, int three) {
+ public TestObjectWithMultipleFields(final int one, final int two, final int three) {
this.one = new TestObject(one);
this.two = new TestObject(two);
this.three = new TestObject(three);
@@ -1113,16 +1113,16 @@ public class EqualsBuilderTest {
@SuppressWarnings("unused")
private final TestObject one;
- public TestObjectReference(int one) {
+ public TestObjectReference(final int one) {
this.one = new TestObject(one);
}
- public void setObjectReference(TestObjectReference reference) {
+ public void setObjectReference(final TestObjectReference reference) {
this.reference = reference;
}
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
return EqualsBuilder.reflectionEquals(this, obj);
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java Tue Jan 22 07:07:42 2013
@@ -31,7 +31,7 @@ public class HashCodeBuilderAndEqualsBui
//-----------------------------------------------------------------------
- private void testInteger(boolean testTransients) {
+ private void testInteger(final boolean testTransients) {
Integer i1 = Integer.valueOf(12345);
Integer i2 = Integer.valueOf(12345);
assertEqualsAndHashCodeContract(i1, i2, testTransients);
@@ -57,7 +57,7 @@ public class HashCodeBuilderAndEqualsBui
testFixture(true);
}
- private void testFixture(boolean testTransients) {
+ private void testFixture(final boolean testTransients) {
assertEqualsAndHashCodeContract(new TestFixture(2, 'c', "Test", (short) 2), new TestFixture(2, 'c', "Test", (short) 2), testTransients);
assertEqualsAndHashCodeContract(
new AllTransientFixture(2, 'c', "Test", (short) 2),
@@ -81,7 +81,7 @@ public class HashCodeBuilderAndEqualsBui
* @param rhs The Right-Hand-Side of the equals test
* @param testTransients wether to test transient fields
*/
- private void assertEqualsAndHashCodeContract(Object lhs, Object rhs, boolean testTransients) {
+ private void assertEqualsAndHashCodeContract(final Object lhs, final Object rhs, final boolean testTransients) {
if (EqualsBuilder.reflectionEquals(lhs, rhs, testTransients)) {
// test a couple of times for consistency.
assertEquals(HashCodeBuilder.reflectionHashCode(lhs, testTransients), HashCodeBuilder.reflectionHashCode(rhs, testTransients));
@@ -96,7 +96,7 @@ public class HashCodeBuilderAndEqualsBui
String string;
short s;
- TestFixture(int i, char c, String string, short s) {
+ TestFixture(final int i, final char c, final String string, final short s) {
this.i = i;
this.c = c;
this.string = string;
@@ -107,7 +107,7 @@ public class HashCodeBuilderAndEqualsBui
static class SubTestFixture extends TestFixture {
transient String tString;
- SubTestFixture(int i, char c, String string, short s, String tString) {
+ SubTestFixture(final int i, final char c, final String string, final short s, final String tString) {
super(i, c, string, s);
this.tString = tString;
}
@@ -119,7 +119,7 @@ public class HashCodeBuilderAndEqualsBui
transient String string;
transient short s;
- AllTransientFixture(int i, char c, String string, short s) {
+ AllTransientFixture(final int i, final char c, final String string, final short s) {
this.i = i;
this.c = c;
this.string = string;
@@ -130,7 +130,7 @@ public class HashCodeBuilderAndEqualsBui
static class SubAllTransientFixture extends AllTransientFixture {
transient String tString;
- SubAllTransientFixture(int i, char c, String string, short s, String tString) {
+ SubAllTransientFixture(final int i, final char c, final String string, final short s, final String tString) {
super(i, c, string, s);
this.tString = tString;
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java Tue Jan 22 07:07:42 2013
@@ -67,12 +67,12 @@ public class HashCodeBuilderTest {
static class TestObject {
private int a;
- public TestObject(int a) {
+ public TestObject(final int a) {
this.a = a;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == this) {
return true;
}
@@ -88,7 +88,7 @@ public class HashCodeBuilderTest {
return a;
}
- public void setA(int a) {
+ public void setA(final int a) {
this.a = a;
}
@@ -107,14 +107,14 @@ public class HashCodeBuilderTest {
super(0);
}
- public TestSubObject(int a, int b, int t) {
+ public TestSubObject(final int a, final int b, final int t) {
super(a);
this.b = b;
this.t = t;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == this) {
return true;
}
@@ -505,7 +505,7 @@ public class HashCodeBuilderTest {
@SuppressWarnings("unused")
private int three = 0;
- public TestObjectWithMultipleFields(int one, int two, int three) {
+ public TestObjectWithMultipleFields(final int one, final int two, final int three) {
this.one = one;
this.two = two;
this.three = three;
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderConcurrencyTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderConcurrencyTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderConcurrencyTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderConcurrencyTest.java Tue Jan 22 07:07:42 2013
@@ -53,7 +53,7 @@ public class ReflectionToStringBuilderCo
static class CollectionHolder<T extends Collection<?>> {
T collection;
- CollectionHolder(T collection) {
+ CollectionHolder(final T collection) {
this.collection = collection;
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java Tue Jan 22 07:07:42 2013
@@ -120,17 +120,17 @@ public class ReflectionToStringBuilderEx
this.validateSecretFieldPresent(toString);
}
- private void validateNonSecretField(String toString) {
+ private void validateNonSecretField(final String toString) {
Assert.assertTrue(toString.indexOf(NOT_SECRET_FIELD) > ArrayUtils.INDEX_NOT_FOUND);
Assert.assertTrue(toString.indexOf(NOT_SECRET_VALUE) > ArrayUtils.INDEX_NOT_FOUND);
}
- private void validateSecretFieldAbsent(String toString) {
+ private void validateSecretFieldAbsent(final String toString) {
Assert.assertEquals(ArrayUtils.INDEX_NOT_FOUND, toString.indexOf(SECRET_VALUE));
this.validateNonSecretField(toString);
}
- private void validateSecretFieldPresent(String toString) {
+ private void validateSecretFieldPresent(final String toString) {
Assert.assertTrue(toString.indexOf(SECRET_VALUE) > 0);
this.validateNonSecretField(toString);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java Tue Jan 22 07:07:42 2013
@@ -63,7 +63,7 @@ public class ReflectionToStringBuilderMu
final private TestFixture testFixture;
final private Random random = new Random();
- public MutatingClient(TestFixture testFixture) {
+ public MutatingClient(final TestFixture testFixture) {
this.testFixture = testFixture;
}
@@ -80,7 +80,7 @@ public class ReflectionToStringBuilderMu
class InspectingClient implements Runnable {
final private TestFixture testFixture;
- public InspectingClient(TestFixture testFixture) {
+ public InspectingClient(final TestFixture testFixture) {
this.testFixture = testFixture;
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java Tue Jan 22 07:07:42 2013
@@ -121,7 +121,7 @@ public class ToStringBuilderTest {
* @param o the object to create the string for.
* @return a String in the Object.toString format.
*/
- private String toBaseString(Object o) {
+ private String toBaseString(final Object o) {
return o.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(o));
}
@@ -140,7 +140,7 @@ public class ToStringBuilderTest {
// Gary Gregory - 2003-03-12 - ggregory@seagullsw.com
//
- public void assertReflectionArray(String expected, Object actual) {
+ public void assertReflectionArray(final String expected, final Object actual) {
if (actual == null) {
// Until ToStringBuilder supports null objects.
return;
@@ -477,7 +477,7 @@ public class ToStringBuilderTest {
public SimpleReflectionTestFixture() {
}
- public SimpleReflectionTestFixture(Object o) {
+ public SimpleReflectionTestFixture(final Object o) {
this.o = o;
}
@@ -994,7 +994,7 @@ public class ToStringBuilderTest {
* @return the String result
* @throws IllegalArgumentException if the Object is <code>null</code>
*/
- public <T> String toStringWithStatics(T object, ToStringStyle style, Class<? super T> reflectUpToClass) {
+ public <T> String toStringWithStatics(final T object, final ToStringStyle style, final Class<? super T> reflectUpToClass) {
return ReflectionToStringBuilder.toString(object, style, false, true, reflectUpToClass);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringStyleConcurrencyTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringStyleConcurrencyTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringStyleConcurrencyTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/ToStringStyleConcurrencyTest.java Tue Jan 22 07:07:42 2013
@@ -50,7 +50,7 @@ public class ToStringStyleConcurrencyTes
static class CollectionHolder<T extends Collection<?>> {
T collection;
- CollectionHolder(T collection) {
+ CollectionHolder(final T collection) {
this.collection = collection;
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BackgroundInitializerTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BackgroundInitializerTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BackgroundInitializerTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BackgroundInitializerTest.java Tue Jan 22 07:07:42 2013
@@ -31,7 +31,7 @@ public class BackgroundInitializerTest {
*
* @param init the initializer to test
*/
- private void checkInitialize(BackgroundInitializerTestImpl init) {
+ private void checkInitialize(final BackgroundInitializerTestImpl init) {
try {
Integer result = init.get();
assertEquals("Wrong result", 1, result.intValue());
@@ -282,7 +282,7 @@ public class BackgroundInitializerTest {
super();
}
- public BackgroundInitializerTestImpl(ExecutorService exec) {
+ public BackgroundInitializerTestImpl(final ExecutorService exec) {
super(exec);
}