You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/23 15:25:32 UTC
[GitHub] [flink] MartijnVisser commented on a diff in pull request #21377: [FLINK-30175][Build] Bump snakeyaml from 1.31 to 1.33
MartijnVisser commented on code in PR #21377:
URL: https://github.com/apache/flink/pull/21377#discussion_r1030579118
##########
pom.xml:
##########
@@ -1707,12 +1707,12 @@ under the License.
<rules>
<bannedDependencies>
<excludes>
- <exclude>org.yaml:snakeyaml:(,1.30]</exclude>
+ <exclude>org.yaml:snakeyaml:(,1.31]</exclude>
</excludes>
<includes>
<!-- Snakeyaml is pulled in by many modules without using it in production,
so there's no benefit in us investing time into bumping these. -->
- <include>org.yaml:snakeyaml:(,1.30]:*:test</include>
+ <include>org.yaml:snakeyaml:(,1.31]:*:test</include>
Review Comment:
I thought about it and decided not to, because snakeyaml 1.32 does not contain a CVE, while everything < 1.32 does. Since this specifically checks for vulnerable snakeyamls, I left this as-is.
##########
pom.xml:
##########
@@ -1707,12 +1707,12 @@ under the License.
<rules>
<bannedDependencies>
<excludes>
- <exclude>org.yaml:snakeyaml:(,1.30]</exclude>
+ <exclude>org.yaml:snakeyaml:(,1.31]</exclude>
</excludes>
<includes>
<!-- Snakeyaml is pulled in by many modules without using it in production,
so there's no benefit in us investing time into bumping these. -->
- <include>org.yaml:snakeyaml:(,1.30]:*:test</include>
+ <include>org.yaml:snakeyaml:(,1.31]:*:test</include>
Review Comment:
I thought about it and decided not to, because snakeyaml 1.32 does not contain a CVE, while everything < 1.32 does. Since this specifically checks for vulnerable snakeyaml versions, I left this as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org