[jira] [Closed] (OFBIZ-7398) Enforce noninstantiability to SolrUtil Class

["Arun Patidar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar closed OFBIZ-7398.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750340

Thanks [~chinmay.patidar] for your contribution.

> Enforce noninstantiability to SolrUtil Class
> --------------------------------------------
>
>                 Key: OFBIZ-7398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7398
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/solr
>    Affects Versions: Trunk
>            Reporter: Arun Patidar
>            Assignee: Arun Patidar
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7398.patch
>
>
> - Add a private constructor.
> - Make the following private static variable as final.
> {code}
>     private static String[] solrProdAttribute = { "productId", "internalName", "manu", "size", "smallImage", "mediumImage", "largeImage", "listPrice", "defaultPrice", "inStock", "isVirtual" };
> {code}
> - Make the following public static variables as private
> {code}
>     public static final String solrConfigName = "solrconfig.properties";
>     public static final String solrUrl = makeSolrWebappUrl();
> {code}
> - Make the following protected static variables as private
> {code}
>     protected static final String socketTimeoutString = UtilProperties.getPropertyValue(solrConfigName, "solr.client.socket.timeout");
>     
>     protected static final String connectionTimeoutString = UtilProperties.getPropertyValue(solrConfigName, "solr.client.connection.timeout");
>     
>     protected static final String clientUsername = UtilProperties.getPropertyValue(solrConfigName, "solr.client.username");
>     
>     protected static final String clientPassword = UtilProperties.getPropertyValue(solrConfigName, "solr.client.password");
>     protected static final Integer socketTimeout = getSocketTimeout();
>     
>     protected static final Integer connectionTimeout = getConnectionTimeout();
>     
>     protected static final String trustSelfSignedCertString = UtilProperties.getPropertyValue(solrConfigName, "solr.client.trust.selfsigned.cert", "false");
>     
>     protected static final boolean trustSelfSignedCert = getTrustSelfSignedCert();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)