You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wilson888888888 <gi...@git.apache.org> on 2015/12/27 07:03:43 UTC
[GitHub] spark pull request: [SPARK-11460][SQL]Add ExpressionDescription to...
GitHub user wilson888888888 opened a pull request:
https://github.com/apache/spark/pull/10486
[SPARK-11460][SQL]Add ExpressionDescription to aggregate functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wilson888888888/spark spark_12460
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10486.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10486
----
commit 1a88a15304bc688a724d56b8cef7ff76c51760b3
Author: Wilson Wu <wi...@gmail.com>
Date: 2015-12-27T05:21:43Z
[SPARK-11460][SQL]Add ExpressionDescription to aggregate functions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12460][SQL]Add ExpressionDescription to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10486#issuecomment-218594234
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12460][SQL]Add ExpressionDescription to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10486
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11460][SQL]Add ExpressionDescription to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10486#issuecomment-167386674
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12460][SQL]Add ExpressionDescription to...
Posted by wilson888888888 <gi...@git.apache.org>.
Github user wilson888888888 commented on the pull request:
https://github.com/apache/spark/pull/10486#issuecomment-167640827
@vectorijk
Thanks. I changed the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11460][SQL]Add ExpressionDescription to...
Posted by vectorijk <gi...@git.apache.org>.
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/10486#issuecomment-167391678
In order to linking this PR to JIRA correctly, you should change title to `[SPARK-12460] ...` rather than `11460`. It is also better to change commit title correspondingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12460][SQL]Add ExpressionDescription to...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10486#issuecomment-216335124
@wilson888888888 I think https://github.com/dongjoon-hyun/spark/commit/a7ce473bd0520c71154ed028f295dab64a7485fe has resolved this issue. Can you close this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org