You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Rakesh R (Commented) (JIRA)" <ji...@apache.org> on 2011/09/27 06:25:12 UTC

[jira] [Commented] (ZOOKEEPER-1100) Killed (or missing) SendThread will cause hanging threads

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115197#comment-13115197 ] 

Rakesh R commented on ZOOKEEPER-1100:
-------------------------------------

Hi,

*Approach:* Added the 'finally block' for the SendThread, this will do the cleanup activities and do graceful shutdown. So all the successive operations will get ConectionLossException and will not be hanged forever.

I have attached the patch, please review.

Thanks in advance,
Rakesh
                
> Killed (or missing) SendThread will cause hanging threads
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-1100
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1100
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>         Environment: http://mail-archives.apache.org/mod_mbox/zookeeper-user/201106.mbox/%3Citpgb6$2mi$1@dough.gmane.org%3E
>            Reporter: Gunnar Wagenknecht
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1100.patch
>
>
> After investigating an issues with [hanging threads|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201106.mbox/%3Citpgb6$2mi$1@dough.gmane.org%3E] I noticed that any java.lang.Error might silently kill the SendThread. Without a SendThread any thread that wants to send something will hang forever. 
> Currently nobody will recognize a SendThread that died. I think at least a state should be flipped (or flag should be set) that causes all further send attempts to fail or to re-spin the connection loop.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira