You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jeff Zhang <zj...@apache.org> on 2016/01/29 02:40:38 UTC
Review Request 42934: [AMBARI-14839] DEA is not enabled due to
configuration conflict and history log directory can not be changed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42934/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Mahadev Konar.
Repository: ambari
Description
-------
This is bug introduced by Ambari-14561
Diffs
-----
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 935c47e
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml d8af790
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml 3b13496
Diff: https://reviews.apache.org/r/42934/diff/
Testing
-------
Verified on HDP 2.4
Thanks,
Jeff Zhang
Re: Review Request 42934: [AMBARI-14839] DEA is not enabled due to
configuration conflict and history log directory can not be changed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42934/#review116959
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 29, 2016, 11:07 a.m., Jeff Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42934/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 11:07 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Mahadev Konar.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is bug introduced by Ambari-14561
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 935c47e
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml d8af790
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml 3b13496
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 5949486
>
> Diff: https://reviews.apache.org/r/42934/diff/
>
>
> Testing
> -------
>
> Verified on HDP 2.4
>
>
> Thanks,
>
> Jeff Zhang
>
>
Re: Review Request 42934: [AMBARI-14839] DEA is not enabled due to
configuration conflict and history log directory can not be changed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42934/#review116963
-----------------------------------------------------------
Committed updated patch to trunk, branch-2.2, and branch-2.2.1 ... you can close the review.
- Jonathan Hurley
On Jan. 29, 2016, 11:07 a.m., Jeff Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42934/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 11:07 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Mahadev Konar.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is bug introduced by Ambari-14561
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 935c47e
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml d8af790
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml 3b13496
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 5949486
>
> Diff: https://reviews.apache.org/r/42934/diff/
>
>
> Testing
> -------
>
> Verified on HDP 2.4
>
>
> Thanks,
>
> Jeff Zhang
>
>
Re: Review Request 42934: [AMBARI-14839] DEA is not enabled due to
configuration conflict and history log directory can not be changed
Posted by Jeff Zhang <zj...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42934/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 4:07 p.m.)
Review request for Ambari, Alejandro Fernandez and Mahadev Konar.
Repository: ambari
Description
-------
This is bug introduced by Ambari-14561
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 935c47e
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml d8af790
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml 3b13496
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 5949486
Diff: https://reviews.apache.org/r/42934/diff/
Testing
-------
Verified on HDP 2.4
Thanks,
Jeff Zhang
Re: Review Request 42934: [AMBARI-14839] DEA is not enabled due to
configuration conflict and history log directory can not be changed
Posted by Jeff Zhang <zj...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42934/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 4:14 a.m.)
Review request for Ambari, Alejandro Fernandez and Mahadev Konar.
Changes
-------
Minor change (address review) if it hasn't been committed
Repository: ambari
Description
-------
This is bug introduced by Ambari-14561
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 935c47e
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml d8af790
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml 3b13496
Diff: https://reviews.apache.org/r/42934/diff/
Testing
-------
Verified on HDP 2.4
Thanks,
Jeff Zhang
Re: Review Request 42934: [AMBARI-14839] DEA is not enabled due to
configuration conflict and history log directory can not be changed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42934/#review116887
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py (lines 89 - 91)
<https://reviews.apache.org/r/42934/#comment177979>
You can simplify this to
spark_history_dir = default('/configurations/spark-defaults/spark.history.fs.logDirectory', "hdfs:///spark-history")
- Jonathan Hurley
On Jan. 28, 2016, 9:22 p.m., Jeff Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42934/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 9:22 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Mahadev Konar.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is bug introduced by Ambari-14561
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 935c47e
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml d8af790
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml 3b13496
>
> Diff: https://reviews.apache.org/r/42934/diff/
>
>
> Testing
> -------
>
> Verified on HDP 2.4
>
>
> Thanks,
>
> Jeff Zhang
>
>
Re: Review Request 42934: [AMBARI-14839] DEA is not enabled due to
configuration conflict and history log directory can not be changed
Posted by Jeff Zhang <zj...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42934/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 2:22 a.m.)
Review request for Ambari, Alejandro Fernandez and Mahadev Konar.
Repository: ambari
Description
-------
This is bug introduced by Ambari-14561
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 935c47e
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml d8af790
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml 3b13496
Diff: https://reviews.apache.org/r/42934/diff/
Testing
-------
Verified on HDP 2.4
Thanks,
Jeff Zhang