[GitHub] [cordova-android] breautek opened a new pull request #764: App bundle

[GitBox <gi...@apache.org>]

breautek opened a new pull request #764: App bundle
URL: https://github.com/apache/cordova-android/pull/764
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   -  Android
   
   
   ### Motivation and Context
   This PR adds support to build android bundle (aab) files.
   Fixes:  #729 
   
   
   
   ### Description
   
   Adds an `--bundle` flag to the `cordova build` command. If present, cordova will do the necessary steps to run the `gradlew bundleDebug` command (or `gradlew bundleRelease` if `--release` flag is present)
   
   This PR does not change the current build commands. Building APKs is still necessary for deploying apps to test devices, or of course to upload to the Google Play store using the traditional way. Bundle files are *exclusively* for deploying to Google Play Store. 
   
   You can however use the google provided `bundletool` program to build APKs from a bundle file so this PR still provides the ability to build bundles in both debug and release variants.
   
   If `build.json` is present in the cordova project, just like building APKs, bundles will automatically be signed using the key and password as defined in `build.json`.
   
   ### Testing
   
   I have done the following:
   - Added unit tests for using the `--bundle` flag
   - Ran `npm test` and ensure all tests passed (Running Node 10.x & cordova@9)
   -  I installed `cordova-android` platform to a test app via `cordova platform add https://github.com/breautek/cordova-android.git#app-bundle` and manually ran build commands and all combinations of `--debug`, `--release`, and `--bundle`
   - I have created a test app on Google Play store to ensure that google will accept a signed aab file created by `cordova build android --bundle --release`.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org